Closed
Bug 895745
Opened 12 years ago
Closed 11 years ago
Polish: Add-on version moves slightly when it is selectd
Categories
(Firefox for Android Graveyard :: Add-on Manager, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 35
People
(Reporter: mkaply, Assigned: Margaret)
References
Details
(Keywords: polish)
Attachments
(1 file)
|
1.30 KB,
patch
|
liuche
:
review+
|
Details | Diff | Splinter Review |
This is purely polish, but it is obvious enough that I think it should be fixed.
If you have add-ons installed in Fennec, touch the first add-on to display it's options/info.
Notice that the version shifts ever so slightly.
Then press back and notice it shifts back.
It shouldn't shift at all.
| Assignee | ||
Comment 1•11 years ago
|
||
Using the remote inspector, I was able to determine this is because there is a space in the details view (which is declared in HTML(, but not in the list view (which is created in JS). This fixes the problem.
Assignee: nobody → margaret.leibovic
Attachment #8501308 -
Flags: review?(liuche)
Comment 2•11 years ago
|
||
Comment on attachment 8501308 [details] [diff] [review]
Don't create whitespace between add-on title and version number in details view
Review of attachment 8501308 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm!
Attachment #8501308 -
Flags: review?(liuche) → review+
| Assignee | ||
Comment 3•11 years ago
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•