Closed Bug 895745 Opened 10 years ago Closed 9 years ago

Polish: Add-on version moves slightly when it is selectd

Categories

(Firefox for Android Graveyard :: Add-on Manager, defect)

Product:
Firefox for Android Graveyard
Component:
Add-on Manager
Version:
24 Branch
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 35

People

(Reporter: mkaply, Assigned: Margaret)

References

Details

(Keywords: polish)

Attachments

(1 file)

Don't create whitespace between add-on title and version number in details view
1.30 KB, patch
liuche
: review+
Details | Diff | Splinter Review 
This is purely polish, but it is obvious enough that I think it should be fixed.

If you have add-ons installed in Fennec, touch the first add-on to display it's options/info.

Notice that the version shifts ever so slightly.

Then press back and notice it shifts back.

It shouldn't shift at all.
Keywords: polish
OS: Maemo → Android
Using the remote inspector, I was able to determine this is because there is a space in the details view (which is declared in HTML(, but not in the list view (which is created in JS). This fixes the problem.
Assignee: nobody → margaret.leibovic
Attachment #8501308 - Flags: review?(liuche)
Blocks: 1053397
Comment on attachment 8501308 [details] [diff] [review]
Don't create whitespace between add-on title and version number in details view

Review of attachment 8501308 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!
Attachment #8501308 - Flags: review?(liuche) → review+
https://hg.mozilla.org/mozilla-central/rev/a1d225fd8168
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.