895803 - controller.open() doesn't work in Metro mode due to missing stop() method on the browser object

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect, P1)

Description

[Andrei Eftimie]

We can't run *any* test under Metro mode atm.
Tracked this regression down to the landing of bug 865641

We need to fix this before the new rc of mozmill 2.0
Bumping priority to P1

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Please make sure to file bugs in the right component, and set the right flags and dependencies. This is not a mozmill-test issue.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Hm, Andrei would you mind to test something for me? What about the following change in controller.js:

-       this.browserObject.stop();
+       this.browserObject.selectedBrowser.stop();

Does that fix the problem for you in Metro mode?

Comment 3

[Andrei Eftimie]

Awesome, that fixes the issue!

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

Turns out that for Firefox Desktop we also have selectedBrowser with the stop() method available. So we can still unify it.

Comment 5

[Andrei Eftimie]

Comment on attachment 778388 [details] [diff] [review]
Patch v1

Review of attachment 778388 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Works fine in both Metro and Desktop mode and under OSX.

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 778388 [details] [diff] [review]
Patch v1

Review of attachment 778388 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks Henrik.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as:
https://github.com/mozilla/mozmill/commit/55be32027cb133f734ebd67f31646c46183c87eb