895817 - [SMS/MMS] From messaging app selecting a contact from facebook to send a message is not working

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[isabelrios]

Unagi device v1-train 07/19 build:
Gecko-6b60535
Gaia-4abea64
ref ril

Import several contacts from facebook with phone number.
STR
1. Create a new message
2. Write some text
3. Tap on '+' icon
4. When te contact list is shown, tap on a facebook contact to select it.

EXPECTED
The contact is added into the 'To' field

ACTUAL
After tapping on the facebook contact, the compose message screen is shown empty. The contact or his number is not added into the 'To' field. 

This is a regression as it is working well on v1.0.1

Comment 1

[Steve Chung [:steveck]]

Hi Isabel,
Since contact data imported from facebook is stored in another database other than mozContact database, it's not possible to get facebook information via phone number in v1.1. Do you accept that we can only show the phone number in this case?(Just like sending the message from contact detail page, we only display number in the to field). BTW, facebook contact could not be found in message app live search result because of the same root cause.

Hi Francisco,
It seems not possible to integrate fb/mozContact database and api in v1.1. Do you have any  brief plan or idea in v1.2 or later version for this issue(Maybe like integrate facebook data into mozContact or set fb lib and data to other proper place for usage)? Thanks.

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Hi Steve,

Unfortunately, this will need to be done via DataStore API that it's not planned in version 1.2

Definitely a must have for 1.3 once is there, to avoid the problem of the communications app where we needed to add several apps just cause of the fb database problem.

As well we cannot integrate the data coming from FB into the mozcontact object cause of the deal with FB, all the FB information must reside in a separate DB and not used by 3rd party apps, thing that will happen if we create a mozContact object with this info.

Cheers,
F.

Comment 3

[Steve Chung [:steveck]]

Attachment: Link to github

Although contact data from facebook does not integrated with mozContact, we still need to handle contact picker in other proper way instead of returning nothing. Fixing in this patch will add number in the recipient field to sync the behavior in v1.0.1

Comment 4

[Noemí Freire (:noemi)]

(In reply to Steve Chung [:steveck] from comment #3)
> Created attachment 781546 [details]
> Link to github
> 
> Although contact data from facebook does not integrated with mozContact, we
> still need to handle contact picker in other proper way instead of returning
> nothing. Fixing in this patch will add number in the recipient field to sync
> the behavior in v1.0.1


Fully agree, we should offer the same behaviour as in v1.0.1 at least, since returning nothing is not valid, because of this we renominate this bug to leo again. Let's open a follow up bug to track the pending work for future versions (via DataStore API). wdyt?

Comment 5

[Andrew Overholt [:overholt]]

Regression = blocker

Comment 6

[Steve Chung [:steveck]]

Landed in mater : 0ecd48ef32576aee9df5789fff48bdfef33fffda

Hi Noemí,
I'll open another follow up bug for facebook/mozContact integration, thanks.

Comment 7

[isabelrios]

The patch is not in v1-train yet. So checked with unagi device 07/30 master build: 
Gecko-f69b55f
Gaia-d8a61ee

When selecting a FB contact with only one phone number and when there are no other contacts in the addressbook, the number is added into the 'To' field correctly. 

But, we have seen several issues related that may require to open follow up bugs:
 - When the Facebook contact has two phone numbers, it appears the dropdown list with the phone numbers and the ‘OK’ button. After tapping on a number, it is automatically added into the ‘To’ field, there is no chance to tap on ‘OK’ button as expected.

 - When the Facebook contact has the same number than a local one, they are not linked (and notice that even the name can be different), the name of the local contact is added into the ‘To’ field instead of the number . I.e: 
*Local contact: Sam 123456789
*Facebook contact: Mike 123456789
Selecting Mike, will add Sam into the ‘To’ field

Comment 8

[Rick Waldron [:rwaldron]]

(In reply to Isabel Rios [:isabel_rios] from comment #7)
>  - When the Facebook contact has two phone numbers, it appears the dropdown
> list with the phone numbers and the ‘OK’ button. After tapping on a number,
> it is automatically added into the ‘To’ field, there is no chance to tap on
> ‘OK’ button as expected.

By "drop down", do you mean the contact search suggestions?


> 
>  - When the Facebook contact has the same number than a local one, they are
> not linked (and notice that even the name can be different), the name of the
> local contact is added into the ‘To’ field instead of the number . I.e: 
> *Local contact: Sam 123456789
> *Facebook contact: Mike 123456789
> Selecting Mike, will add Sam into the ‘To’ field

This is an issue for Contacts to sort out, the SMS/MMS app only displays what it receives from the platform.

Comment 9

[isabelrios]

(In reply to Rick Waldron from comment #8)
> (In reply to Isabel Rios [:isabel_rios] from comment #7)
> >  - When the Facebook contact has two phone numbers, it appears the dropdown
> > list with the phone numbers and the ‘OK’ button. After tapping on a number,
> > it is automatically added into the ‘To’ field, there is no chance to tap on
> > ‘OK’ button as expected.
> 
> By "drop down", do you mean the contact search suggestions?

It is the screen showing the list of numbers that contact has. Please see screenshot attached.
 
> >  - When the Facebook contact has the same number than a local one, they are
> > not linked (and notice that even the name can be different), the name of the
> > local contact is added into the ‘To’ field instead of the number . I.e: 
> > *Local contact: Sam 123456789
> > *Facebook contact: Mike 123456789
> > Selecting Mike, will add Sam into the ‘To’ field
> 
> This is an issue for Contacts to sort out, the SMS/MMS app only displays
> what it receives from the platform.

Ok, thanks. I will check if that has been already filed and if not, create a new bug.

Comment 10

[isabelrios]

Attachment: 2013-07-31-08-29-32.png

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 0ecd48ef32576aee9df5789fff48bdfef33fffda to:
v1-train: 213ccf3cad5fc0797c36e3ca51f3a3877002eff3

Comment 12

[isabelrios]

Two follow up bugs:
For case #1 bug900379:
> > When the contact has two phone numbers, it appears the dropdown
> > list with the phone numbers and the ‘OK’ button. After tapping on a number,
> > it is automatically added into the ‘To’ field, there is no chance to tap on
> > ‘OK’ button as expected.

For case #2 bug900391:
> > When the Facebook contact has the same number than a local one, they are
> > not linked (and notice that even the name can be different), the name of the
> > local contact is added into the ‘To’ field instead of the number . I.e: 
> > *Local contact: Sam 123456789
> > *Facebook contact: Mike 123456789
> > Selecting Mike, will add Sam into the ‘To’ field

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 213ccf3cad5fc0797c36e3ca51f3a3877002eff3

Comment 14

[isabelrios]

The problem described in comment 0 is already fixed.
Checked with unagi device 08/07 v1-train build:
Gecko-70e8636
Gaia-60ca816
ref ril

Bug the two bugs described in comment 12 are not yet.