Closed
Bug 895822
Opened 11 years ago
Closed 11 years ago
[AudioManager] The instance of AudioManager doesn't be created for monitoring the headset status.
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mchen, Assigned: mchen)
References
Details
Attachments
(1 file, 1 obsolete file)
1.49 KB,
patch
|
mchen
:
review+
|
Details | Diff | Splinter Review |
Bug 876334 removed codes related to AudioManager from shell.js/settings.js to AudioChannelManager.cpp and AudioManager.cpp. Originally the instance of AudioManager was created by shell.js during b2g boot up. Now it is created by AudioChannelService::Observer() corresponding to the volume control. Before any volume control is fired, the AudioManager is not created so there is no one register to monitor headphone status from GonkSwitch.cpp. Then routing for headphone is processed even GonkSwitch is working well. This bug will try to find a way to initialize AudioManager during b2g boot up flow.
Assignee | ||
Comment 1•11 years ago
|
||
Hi Dave, May I know your suggestion about putting initialization of AudioManager instance on the position as below? http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/SystemWorkerManager.cpp#346 The AudioManager should be created during boot process because it is used to monitor the headset plugin/pull out by the notification from GonkSwitch.cpp. And now it is just created by AudioChannelService when user pressed volume key then adjusting volume via AudioManager. So I think it should be created early like what automounter did there. Thanks.
Flags: needinfo?(dhylands)
Comment 2•11 years ago
|
||
It seems like a reasonable place to put initialization for any of the code in dom/system/gonk. Just keep in mind that it's running on the main thread.
Flags: needinfo?(dhylands)
Assignee | ||
Comment 3•11 years ago
|
||
Thanks for kindly reply and AudioManager is running on the main thread indeed.
Assignee | ||
Comment 4•11 years ago
|
||
Hi Dave, This patch is used to create a service of AudioManager during boot up process so it can monitor the headset pluggin change and initialize the configuration of audio backend - AudioFlinger. Thanks.
Attachment #787409 -
Flags: review?(dhylands)
Updated•11 years ago
|
Attachment #787409 -
Flags: review?(dhylands) → review+
Assignee | ||
Comment 5•11 years ago
|
||
All green on try server. https://tbpl.mozilla.org/?tree=Try&rev=2a2dbea342d1
Assignee | ||
Comment 6•11 years ago
|
||
Carry the reviewer's name and add keyword - checkin-needed.
Attachment #787409 -
Attachment is obsolete: true
Attachment #789432 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/d62a5b269536
Keywords: checkin-needed
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d62a5b269536
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•