Closed
Bug 895827
Opened 11 years ago
Closed 11 years ago
Don't use aTargetArea.childElementCount to determine where to insert widgets if we can't find a better location
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: Gijs, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Australis:M8][Australis:P3])
Attachments
(1 file)
|
1.55 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
Spun off from bug 885075 comment 2: Because [the drop target] doesn't occur in placements, when we drop something on top of it, we get a null placement, which means we use aTargetArea.childElementCount instead. This last part is wrong already, I think; we should be using the maximum placement index (which could be higher - and is, in the case of the navbar - or lower). Jared, is that correct?
|
||
Comment 1•11 years ago
|
||
Without digging too deep, that sounds all correct.
|
Assignee | |
Comment 2•11 years ago
|
||
Simpler than I thought; moveWidgetWithinArea and addWidgetToArea both deal with passing null as the position and will pick placements.length
Attachment #779097 -
Flags: review?(jaws)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → gijskruitbosch+bugs
|
|
||
Updated•11 years ago
|
Attachment #779097 -
Flags: review?(jaws) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/projects/ux/rev/d27aea6a2eee
Whiteboard: [Australis:P3] → [Australis:M8][Australis:P3][fixed-in-ux]
|
|
Assignee | |
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d27aea6a2eee
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M8][Australis:P3][fixed-in-ux] → [Australis:M8][Australis:P3]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•