895835 - Create a folder in mozqa.com that's behind basic authentication for testing

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Infrastructure, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

In order to test mozdownload's ability to download from URLs protected by basic authentication, we need at least one file on mozqa.com to have such authentication.

I would suggest mozqa.com/basicauth/index.html or similar.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Sushant, would you be interested to help us on this bug? Not sure if you know about the Apache config, but please let us know. I think that's not too hard to do.

Comment 2

[Sushant Hiray [:sushant]]

Henrik,

I would love to give it a shot. I've played with config files but in a very basic level. I will read up some stuff if needed. No issues with that.

Could you give me a head start?

Regards,
Sushant

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

http://httpd.apache.org/docs/2.2/howto/auth.html should put you in the right direction. We just want basic authentication for now, but we should leave ourselves open to support other types in the future. For that reason I think we should have the structure as below:

mozqa.com/auth/basic/index.html

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Great. Thanks, so I will assign this bug to you then. The link Dave has been given is more an overview. What we need here is a .htaccess and .htpasswd file for that folder. You can read information about it on the following page:

http://httpd.apache.org/docs/current/howto/htaccess.html

Comment 5

[Sushant Hiray [:sushant]]

Dear Henrik,

I've read about authentication and it seems pretty trivial. Could you give me the link of mozqa.com repository so that I can go about cloning it and creating a patch?

Regards,
Sushant

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Sushant, it is the same repository you have worked with before for the HTML testcase changes. You can find it here: http://hg.mozilla.org/qa/testcase-data/

We simply have a clone on mozqa.com which automatically pulls each 15mins for updates.

Comment 7

[Sushant Hiray [:sushant]]

Henrik, I searched if it is possible to put relative paths to .htpasswd file. But as it turns out from my brief search, this is possible only if we create some environment variable.
So what path should I give for the file?

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

At the following page I found that it should be possible but it will be the relative path from the server root:

http://stackoverflow.com/questions/6111627/htaccess-authuserfile-relative-path

File-path is the path to the user file. If it is not absolute (i.e., if it doesn't begin with a slash), it is treated as relative to the ServerRoot.

Comment 9

[Sushant Hiray [:sushant]]

Henrik,
I had seen that link earlier. But as it seems, he wanted to have it relative to .htaccess and which is why he didn't mark that answer as correct but in our case relative to server root will as well suffice so no issues.

I'll submit a patch shortly

Comment 10

[Sushant Hiray [:sushant]]

Attachment: Bug-895835.patch Added Basic Authentication

I've as well added an index.html for checking. I've assumed that the mozqa.com is in the server root directory.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

The file structure you can find here:
http://mozqa.com/data/

So we might have to include ´data´ here. I could have a spot-check tomorrow on the server if that would work. But for today I'm off now.

Comment 12

[Sushant Hiray [:sushant]]

Attachment: Bug-895835.patch Basic Authentication added || File path corrected

Updated the relative path to start from data.
You can try it on server and let me know if we face some issue!

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Comment on attachment 779949 [details] [diff] [review]
Bug-895835.patch Basic Authentication added || File path corrected

Review of attachment 779949 [details] [diff] [review]:
-----------------------------------------------------------------

Ok, I have experimented on mozqa.com and we definitely have to use the absolute path to the .htpasswd file. So please see my inline comments in how we get this working.

::: webapps/mozqa.com/auth/.htaccess
@@ +1,2 @@
> +AuthType Basic
> +AuthName "Mozilla's Protected Area"

For the name please add that it is for testing the basic authentication. Also mention that the user/pass is: mozilla/mozilla

@@ +1,3 @@
> +AuthType Basic
> +AuthName "Mozilla's Protected Area"
> +AuthUserFile data/webapps/mozqa.com/auth/.htpasswd

I would suggest we place the basic http auth under data/http_auth/basic/. The .htaccess will have to look like:

AuthType Basic
AuthName "Mozilla's Protected Area"
AuthUserFile /data/www/mozqa.com/data/http_auth/basic/.htpasswd
Require valid-user

::: webapps/mozqa.com/auth/.htpasswd
@@ +1,1 @@
> +root:$apr1$gWxGN4rO$lvq8/208nOcRS0LPFUQBU/

Please change that line to: ´mozilla:J.BZscAH9P43k´

::: webapps/mozqa.com/auth/basic/index.html
@@ +3,5 @@
> +  <head>
> +    <title>MozQA</title>
> +   </head>
> +   <body>
> +	 <h1> Mozilla QA Infrastructure</h1>

Just use a normal p tag here, which should then say that the basic auth was successful. Please also keep the 2 char indentation.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Sushant, have you had time to check my review comments?

Comment 15

[Sushant Hiray [:sushant]]

Attachment: 895835.patch

I was a bit busy with my exams. I have made the changes. Hope this looks good :)

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Comment on attachment 795067 [details] [diff] [review]
895835.patch

Review of attachment 795067 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Just two nits to fix before we can get this landed.

::: webapps/mozqa.com/data/http_auth/basic/.htaccess
@@ +1,3 @@
> +
> + AuthType basic
> + AuthName "Mozilla-Protected Zone: Basic Authentication user/pass:mozilla/mozilla"

I would drop some of those colons and say: ´Basic Authentication for Tests - user: mozilla / password: mozilla´

::: webapps/mozqa.com/data/http_auth/basic/index.html
@@ +1,4 @@
> +<html>
> +  <head>Mozilla Protected Area</head>
> +  <body>
> +    <p>Authentication is successful!</p>

nit: 'Basic Authentication'

Comment 17

[Sushant Hiray [:sushant]]

Attachment: Bug-895835.patch Basic Authentication in mozqa

I guess this should suffice!

Comment 18

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Comment on attachment 795847 [details] [diff] [review]
Bug-895835.patch Basic Authentication in mozqa

Review of attachment 795847 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, that looks perfect. Thanks for your work!

I will land it right now, so we can see how it works and we can create tests for mozdownload. Would you be interested to create such a test?

Comment 19

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Comment on attachment 795847 [details] [diff] [review]
Bug-895835.patch Basic Authentication in mozqa

Review of attachment 795847 [details] [diff] [review]:
-----------------------------------------------------------------

Landed as:
http://hg.mozilla.org/qa/testcase-data/rev/6433b1736f0e

And I had to back this out given that the folder structure is not correct. Those files should not exist under webapps but under the root folder.

Backout:
http://hg.mozilla.org/qa/testcase-data/rev/4aaa429d8dd2

Comment 20

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

(In reply to Henrik Skupin (:whimboo) from comment #18)
> I will land it right now, so we can see how it works and we can create tests
> for mozdownload. Would you be interested to create such a test?

https://github.com/mozilla/mozdownload/issues/141 will cover the mozdownload case.

Comment 21

[Sushant Hiray [:sushant]]

Attachment: 895835.patch

I've copied the entire mozqa.com folder into the root folder of testcase-data.
I reverted the mozqa.com folder as it was before I started changing in the webapps dir.
Since I added the image as well, patch is pretty big.

So 2 doubts:
Do we need to keep the image?
Should I remove mozqa.com entirely from webapps directory?

Comment 22

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Comment on attachment 795949 [details] [diff] [review]
895835.patch

Review of attachment 795949 [details] [diff] [review]:
-----------------------------------------------------------------

In general please do not touch anything from the webapps sub folder. We only care about our HTTP auth files here. If there has to be done more, lets file a follow-up bug. More comments inline.

::: mozqa.com/data/http_auth/basic/.htaccess
@@ +1,4 @@
> +
> + AuthType basic
> + AuthName "Basic Authentication for Tests - user: mozilla / password: mozilla"
> + AuthUserFile /data/www/mozqa.com/data/http_auth/basic/.htpasswd

You have moved the folder. So this path needs an update. FYI the folder ´/data/www/mozqa.com/data´ is the web root. So adjust the suffix accordingly to 'mozqa.com/http_auth/...'.

Comment 23

[Sushant Hiray [:sushant]]

Attachment: Bug-895835.patch Basic Authentication in mozqa

Well, I have changed the path.
So now, I have assumed that we are keeping the mozqa.com folder in the web root folder.

Comment 24

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Comment on attachment 796163 [details] [diff] [review]
Bug-895835.patch Basic Authentication in mozqa

Review of attachment 796163 [details] [diff] [review]:
-----------------------------------------------------------------

There are still two problems to be fixed. Once that has been done we are good.

::: mozqa.com/appinstall.html
@@ +1,1 @@
> +<!DOCTYPE html>

Again, this file is not part of our changes. Leave it where it was before.

::: mozqa.com/manifest.webapp
@@ +1,1 @@
> +{

Same here. Please do not move this file.

Comment 25

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Oh, and also ensure that you do not move any binary file too.

Comment 26

[Sushant Hiray [:sushant]]

Attachment: 895835.patch

Removed the appinstall.html, manifest.webapp and qalogo.png
I guess we are through now.

Comment 27

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Comment on attachment 796629 [details] [diff] [review]
895835.patch

Review of attachment 796629 [details] [diff] [review]:
-----------------------------------------------------------------

That looks good now. I landed it as:
http://hg.mozilla.org/qa/testcase-data/rev/945882d0fd7f

Comment 28

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Ok, so this is available now via:
http://mozqa.com/data/mozqa.com/http_auth/basic/

Sadly we do not see the basic folder listed under:
http://mozqa.com/data/mozqa.com/http_auth

Sushant, would you mind to create a follow-up patch, which adds a new index.html file into that folder? I should include a quick description and links to all supported auth methods.

Comment 29

[Sushant Hiray [:sushant]]

So an index.html in http_auth right?
Are you gonna include the description and links to supported auth methods or was it a typo?

Comment 30

[Sushant Hiray [:sushant]]

Attachment: 895835.patch

Added an index.html in http_auth to access various authentication links.
Currently only link for basic authentication in provided! Might need some changes as other authentication types are added!

Comment 31

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Comment on attachment 797159 [details] [diff] [review]
895835.patch

Review of attachment 797159 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like you haven't updated your local repository before creating the new patch. Please run a ´hg pull -u´ before.

::: mozqa.com/http_auth/index.html
@@ +2,5 @@
> +  <head>Mozilla Protected Area</head>
> +  <body>
> +    <p>Supported Authentication Types:</p>
> +    <ul>
> +	  <li><a href="basic/index.html">Basic Authentication</a></li>

2 chars of indentation please. Also you can remote the ´index.html´ part of the link. Apache takes this automatically.

Comment 32

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Comment on attachment 796629 [details] [diff] [review]
895835.patch

This patch is not obsolete. It has been landed.

Comment 33

[Sushant Hiray [:sushant]]

Attachment: 895835-2.patch

Aah, I get it. I hadn't pulled from the source, so I had to mark the previous one as obsolete.
Now I guess this looks fine.

Comment 34

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Comment on attachment 797393 [details] [diff] [review]
895835-2.patch

Review of attachment 797393 [details] [diff] [review]:
-----------------------------------------------------------------

General that looks fine now but see my inline comment.

::: mozqa.com/http_auth/index.html
@@ +4,5 @@
> +	<p>The following are the supported authentication types:</p>
> +	<ul>
> +		<li>
> +			<a href="basic/">Basic Authentication</a>
> +		</li>

All the indentation in that file is off. Please do not use tabs but 2 spaces. Your editor might have to be configured appropriately.

Comment 35

[Sushant Hiray [:sushant]]

Oops. I just checked and I seem to have changed the preferences some time back.
Anyways no issues, I have changed the settings.
Hope this looks fine!

Comment 36

[Sushant Hiray [:sushant]]

Attachment: 895835-2.patch Updated indentation

Comment 37

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Comment on attachment 798154 [details] [diff] [review]
895835-2.patch Updated indentation

Review of attachment 798154 [details] [diff] [review]:
-----------------------------------------------------------------

That looks way better now.

Comment 38

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Landed as:
http://hg.mozilla.org/qa/testcase-data/rev/d5dd4b52f554

Sushant, would you be interested to implement other authentication methods, or more on creating an automated test for mozdownload as pointed out already above? Let me know if you have interests!

Comment 39

[Sushant Hiray [:sushant]]

Henrik, I would surely love to help more. Depending on the priority we can either work first on the test for mozdownload or implement new auth methods. :)
Do link me accordingly to the appropriate bug/issue.

Comment 40

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

I talked with Sushant on IRC and he will work on the automated test for mozdownload now.