895875 - [BB][RTL] Drawer is messed up when used in RTL languages

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Ahmed Nefzaoui [:Nefzaoui]]

Attachment: Drawer_status.jpg

User Agent: Mozilla/5.0 (Windows NT 6.2; rv:25.0) Gecko/20130716 Firefox/25.0 (Nightly/Aurora)
Build ID: 20130716030202



Actual results:

Using Firefox OS in Arabic causes a little (too much) of a chaos in building blocks. Most elements that live in Shared/style and shared/style_unstable need to get support for dir="rtl" cases.
Screenshots show the current status without RTL support.
Note that what you see is after I finished working on bug 883673, I was even worse.

Comment 1

[Stephany Wilkes]

Ahmed, at risk of abusing your time, can you confirm if these drawer issues happen in 2.0? I ask because there are a lot of changes to these areas in 2.0. If they still exist, we can add these to the RTL backlog for 2.1. Thanks!

Comment 2

[Ahmed Nefzaoui [:Nefzaoui]]

No it's fine :)
Just checked, they still exists, I'll submit a patch.
BTW, do we have a deadline ?

Comment 3

[Stephany Wilkes]

Thanks, Ahmed! There is no deadline. I am just trying to find Arabic language and RTL improvements that (if low risk) might make gaia approval for 2.0, and if not it can land in 2.1. Thanks!

Comment 4

[Ahmed Nefzaoui [:Nefzaoui]]

Attachment: PR to Github

However I'm not sure about who to flag for r?
Stephany, is that you who should I be flagging?

Comment 5

[Stephany Wilkes]

Hi Ahmed,

Very sorry for the delay. If you click on Details, you will see a new set of flags. If you go to set the "review" ? you will "suggested reviewers" appear and you should choose one of those suggested people. Please let me know if you have any other questions. Thanks!

Comment 6

[[:fabrice] Fabrice Desré]

Comment on attachment 8441938 [details] [review]
PR to Github

Redirecting the review to Tim.

Comment 7

[Carsten Book [:Tomcat]]

master: https://github.com/mozilla-b2g/gaia/commit/5a804cb3b3dc348927c1912d1e6f1b21d91b3826

Comment 8

[[:RJ]]

Issue is verified fixed on 2.1 flame and 2.0 flame 

Drawers are aligned correctly and look like they are no longer broken.

Flame 2.1

Device: Flame 2.1 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141126001202
Gaia: db2e84860f5a7cc334464618c6ea9e92ff82e9dd
Gecko: 211eae88f119
Version: 34.0 (2.1)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.0

Device: Flame 2.0 (319mb)(Kitkat Base)(Shallow Flash)
Build ID: 20141126000203
Gaia: f9d6e3d83c3922e9399a6c27f5ce4cdd27bdfd05
Gecko: 45112935086f
Version: 32.0 (2.0)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 9

[Peter Bylenga [:PBylenga]]

Mass Edit: adding the [rtl-meta]