895999 - Comm-Central icon optimization

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Josiah Bruner [:jsbruner]]

Quite a few of the icons around the tree really need optimization, while others need very little. However, instead of ignoring the "small" icons, I went ahead and optimized as much as possible. Although many of these icons were barely reduced there isn't really a reason to not land this.

OS X shows the mail folder reducing from 15.4 to 15.3 MB after these patches.

Comment 1

[Josiah Bruner [:jsbruner]]

More calculations indicate a reduction of 153.52 kB.

Comment 2

[Josiah Bruner [:jsbruner]]

Attachment: Part 1 - Shared icons

Comment 3

[Josiah Bruner [:jsbruner]]

Attachment: Part 2 - Linux

Comment 4

[Josiah Bruner [:jsbruner]]

Attachment: Part 3 - OS X

Comment 5

[Josiah Bruner [:jsbruner]]

Attachment: Part 4 - Windows

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 778601 [details] [diff] [review]
Part 2 - Linux

Please can you remove faceted.background.png completely? It isn't used (also not in jar.mn) but check again to be sure.

r+ with this done.

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 778602 [details] [diff] [review]
Part 3 - OS X

Again can you remove faceted-background.png and additionally animation.png?

r+ with this done.

Comment 8

[Richard Marti (:Paenglab)]

Comment on attachment 778603 [details] [diff] [review]
Part 4 - Windows

And the last time, bye bye faceted-background.png ;)

r+ with this done.

Comment 9

[Richard Marti (:Paenglab)]

All in all thank you for doing this. I always tried to compress the files I touched but it had a lot beside of them.

I saw in linux/mail/preferences the files background.png, hover.png and selected.png are remnants from Windows and unused and can also be removed. But I think this should be done in a new bug as also the jar.mn needs changed.

Comment 10

[Josiah Bruner [:jsbruner]]

Attachment: Part 2 - Linux ui-r+r=Paenglab

Comment 11

[Josiah Bruner [:jsbruner]]

Attachment: Part 3 - OS X ui-r+r=Paenglab

Comment 12

[Josiah Bruner [:jsbruner]]

Attachment: Part 4 - Windows ui-r+r=Paenglab

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/e3321c008575
https://hg.mozilla.org/comm-central/rev/3259ad5fddb2
https://hg.mozilla.org/comm-central/rev/24f8a04ba24c
https://hg.mozilla.org/comm-central/rev/554332581c15

Comment 14

[:aceman]

Can you please clarify what the "optimization" did? Was it just some automatic recompression of png files using higher compression level or safe reductions of color space (less bits per color) ? Without any change to the visible representation of the icons?

Comment 15

[Josiah Bruner [:jsbruner]]

(In reply to :aceman from comment #14)
> Can you please clarify what the "optimization" did? Was it just some
> automatic recompression of png files using higher compression level or safe
> reductions of color space (less bits per color) ? Without any change to the
> visible representation of the icons?

Sure. This included a few things:

Compression - Using some automatic compression algorithms of pngs. This included some reductions in color space. In addition some manual optimizations were done to remove useless alpha aware color pixels. (When a color pixel accidentally has a very low amount of transparency that isn't even visible) Also, for larger files removal of useless pixels was done. 

Icon removal - Removing obsolete icons. 

Icon adjustments - While I was at it I updated some OS X icons slightly since they were slightly off (color-wise) 

Hope that clarifies is!

Comment 16

[:aceman]

Yes, great!