Closed Bug 895999 Opened 8 years ago Closed 8 years ago

Comm-Central icon optimization

Categories

(Thunderbird :: Theme, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 25.0

People

(Reporter: jsbruner, Assigned: jsbruner)

Details

Attachments

(4 files, 3 obsolete files)

Quite a few of the icons around the tree really need optimization, while others need very little. However, instead of ignoring the "small" icons, I went ahead and optimized as much as possible. Although many of these icons were barely reduced there isn't really a reason to not land this.

OS X shows the mail folder reducing from 15.4 to 15.3 MB after these patches.
More calculations indicate a reduction of 153.52 kB.
Attached patch Part 2 - Linux (obsolete) β€” β€” Splinter Review
Attached patch Part 3 - OS X (obsolete) β€” β€” Splinter Review
Attached patch Part 4 - Windows (obsolete) β€” β€” Splinter Review
Attachment #778600 - Flags: ui-review?(richard.marti)
Attachment #778600 - Flags: review?(richard.marti)
Attachment #778601 - Flags: ui-review?(richard.marti)
Attachment #778601 - Flags: review?(richard.marti)
Attachment #778602 - Flags: ui-review?(richard.marti)
Attachment #778602 - Flags: review?(richard.marti)
Attachment #778603 - Flags: ui-review?(richard.marti)
Attachment #778603 - Flags: review?(richard.marti)
Attachment #778600 - Flags: ui-review?(richard.marti)
Attachment #778600 - Flags: ui-review+
Attachment #778600 - Flags: review?(richard.marti)
Attachment #778600 - Flags: review+
Comment on attachment 778601 [details] [diff] [review]
Part 2 - Linux

Please can you remove faceted.background.png completely? It isn't used (also not in jar.mn) but check again to be sure.

r+ with this done.
Attachment #778601 - Flags: ui-review?(richard.marti)
Attachment #778601 - Flags: ui-review+
Attachment #778601 - Flags: review?(richard.marti)
Attachment #778601 - Flags: review+
Comment on attachment 778602 [details] [diff] [review]
Part 3 - OS X

Again can you remove faceted-background.png and additionally animation.png?

r+ with this done.
Attachment #778602 - Flags: ui-review?(richard.marti)
Attachment #778602 - Flags: ui-review+
Attachment #778602 - Flags: review?(richard.marti)
Attachment #778602 - Flags: review+
Comment on attachment 778603 [details] [diff] [review]
Part 4 - Windows

And the last time, bye bye faceted-background.png ;)

r+ with this done.
Attachment #778603 - Flags: ui-review?(richard.marti)
Attachment #778603 - Flags: ui-review+
Attachment #778603 - Flags: review?(richard.marti)
Attachment #778603 - Flags: review+
All in all thank you for doing this. I always tried to compress the files I touched but it had a lot beside of them.

I saw in linux/mail/preferences the files background.png, hover.png and selected.png are remnants from Windows and unused and can also be removed. But I think this should be done in a new bug as also the jar.mn needs changed.
Attachment #778601 - Attachment is obsolete: true
Attachment #778896 - Flags: ui-review+
Attachment #778896 - Flags: review+
Attachment #778602 - Attachment is obsolete: true
Attachment #778897 - Flags: ui-review+
Attachment #778897 - Flags: review+
Attachment #778603 - Attachment is obsolete: true
Attachment #778898 - Flags: ui-review+
Attachment #778898 - Flags: review+
Can you please clarify what the "optimization" did? Was it just some automatic recompression of png files using higher compression level or safe reductions of color space (less bits per color) ? Without any change to the visible representation of the icons?
(In reply to :aceman from comment #14)
> Can you please clarify what the "optimization" did? Was it just some
> automatic recompression of png files using higher compression level or safe
> reductions of color space (less bits per color) ? Without any change to the
> visible representation of the icons?

Sure. This included a few things:

Compression - Using some automatic compression algorithms of pngs. This included some reductions in color space. In addition some manual optimizations were done to remove useless alpha aware color pixels. (When a color pixel accidentally has a very low amount of transparency that isn't even visible) Also, for larger files removal of useless pixels was done. 

Icon removal - Removing obsolete icons. 

Icon adjustments - While I was at it I updated some OS X icons slightly since they were slightly off (color-wise) 

Hope that clarifies is!
Yes, great!
You need to log in before you can comment on or make changes to this bug.