896028 - Add a standard Makefile rule to build mochitest-metro test files

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Bug 803671 added a new "mochitest-metro-chrome" suite, similar to mochitest-a11y.  We are using a couple of different ad-hoc rules for installing files to _tests/testing/mochitest/metro.  This adds a standard rule to mochitest.mk and converts existing Makefiles to use that instead.

Comment 1

[Gregory Szorc [:gps]]

Comment on attachment 778637 [details] [diff] [review]
patch

Review of attachment 778637 [details] [diff] [review]:
-----------------------------------------------------------------

All new build config variables should be in moz.build files.

That being said, mochitests are scheduled to move to manifests (bug 868158). So, I'm not sure what the least evil thing to do here is.

jmaher: what's the ETA on mochitest manifests?

Comment 2

[Joel Maher ( :jmaher ) (UTC -0800)]

I spent a couple hours working on the mochitest manifest patch, I have 1 more thing to address and final testing.  I will be deployed sometime next week.

Comment 3

[Matt Brubeck (:mbrubeck)]

I pushed this to Try before seeing the comments above.
https://tbpl.mozilla.org/?tree=Try&rev=9459dca18bf8

It sounds like we can just close this bug as WONTFIX, assuming bug 868158 will get rid of these Makefile lists completely.  Do you agree, gps?

Comment 4

[Joel Maher ( :jmaher ) (UTC -0800)]

to be clear, my manifest patch is the plumbing in the harnesses, not cleaning out makefiles.

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 778637 [details] [diff] [review]
patch

Review of attachment 778637 [details] [diff] [review]:
-----------------------------------------------------------------

This is better than what's in the tree now. I'd like this stuff to be in moz.build and/or manifests, but that can wait.

Comment 6

[Matt Brubeck (:mbrubeck)]

Okay, thanks.  And hopefully this patch will make the eventual "manifestation" easier.

Comment 7

[Matt Brubeck (:mbrubeck)]

Fixed check-sync-dirs error: https://tbpl.mozilla.org/?tree=Try&rev=5c7401c108be

Comment 8

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/755f8ba7da63

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/755f8ba7da63