Closed
Bug 896028
Opened 8 years ago
Closed 8 years ago
Add a standard Makefile rule to build mochitest-metro test files
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla25
People
(Reporter: mbrubeck, Assigned: mbrubeck)
References
Details
Attachments
(1 file)
8.05 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
Bug 803671 added a new "mochitest-metro-chrome" suite, similar to mochitest-a11y. We are using a couple of different ad-hoc rules for installing files to _tests/testing/mochitest/metro. This adds a standard rule to mochitest.mk and converts existing Makefiles to use that instead.
Attachment #778637 -
Flags: review?(gps)
Comment 1•8 years ago
|
||
Comment on attachment 778637 [details] [diff] [review] patch Review of attachment 778637 [details] [diff] [review]: ----------------------------------------------------------------- All new build config variables should be in moz.build files. That being said, mochitests are scheduled to move to manifests (bug 868158). So, I'm not sure what the least evil thing to do here is. jmaher: what's the ETA on mochitest manifests?
Attachment #778637 -
Flags: feedback?(jmaher)
Comment 2•8 years ago
|
||
I spent a couple hours working on the mochitest manifest patch, I have 1 more thing to address and final testing. I will be deployed sometime next week.
Assignee | ||
Comment 3•8 years ago
|
||
I pushed this to Try before seeing the comments above. https://tbpl.mozilla.org/?tree=Try&rev=9459dca18bf8 It sounds like we can just close this bug as WONTFIX, assuming bug 868158 will get rid of these Makefile lists completely. Do you agree, gps?
Comment 4•8 years ago
|
||
to be clear, my manifest patch is the plumbing in the harnesses, not cleaning out makefiles.
Comment 5•8 years ago
|
||
Comment on attachment 778637 [details] [diff] [review] patch Review of attachment 778637 [details] [diff] [review]: ----------------------------------------------------------------- This is better than what's in the tree now. I'd like this stuff to be in moz.build and/or manifests, but that can wait.
Attachment #778637 -
Flags: review?(gps) → review+
Assignee | ||
Comment 6•8 years ago
|
||
Okay, thanks. And hopefully this patch will make the eventual "manifestation" easier.
Assignee | ||
Comment 7•8 years ago
|
||
Fixed check-sync-dirs error: https://tbpl.mozilla.org/?tree=Try&rev=5c7401c108be
Assignee | ||
Comment 8•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/755f8ba7da63
Flags: in-testsuite-
Assignee | ||
Updated•8 years ago
|
Attachment #778637 -
Flags: feedback?(jmaher)
Comment 9•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/755f8ba7da63
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Updated•7 years ago
|
OS: Windows 8 Metro → Windows 8.1
Updated•3 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•