896032 - nsGtkKeyUtils.cpp:552:18: warning: unused variable 'rv' [-Wunused-variable]

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Daniel Holbert [:dholbert]]

Build (warning when building on Linux, with clang):
> widget/gtk2/nsGtkKeyUtils.cpp:552:18: warning: unused variable 'rv' [-Wunused-variable]
>   nsresult rv = CallGetService("@mozilla.org/widget/bidikeyboard;1", &sBidiKeyboard);

This was added last week for Bug 817508, here:
 http://hg.mozilla.org/mozilla-central/rev/1adc72e64db0#l3.70

Sine this is in a function that returns void, I'm not sure if we can usefully react to failures in 'rv'. Maybe we should just directly invoke CallGetService, and not bother capturing its return value? We do that in several places elsewhere, FWIW.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1: drop 'rv'

Comment 2

[Simon Montagu :smontagu]

Comment on attachment 778646 [details] [diff] [review]
fix v1: drop 'rv'

Review of attachment 778646 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for picking this up. I had made the same change myself at the last minute (after the change Karl requested in bug 817508 comment 12 left the rv hanging) but obviously forgot to refresh the patch.

Comment 3

[Daniel Holbert [:dholbert]]

Thanks! Incidentally, this leaves this directory build-warning-free, as shown by this Try run w/ an additional FAIL_ON_WARNINGS patch:
 https://tbpl.mozilla.org/?tree=Try&rev=a91dc7de7077

I'll file a followup bug on doing that annotation.

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c525538afb69

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c525538afb69