896034 - Send an email when a region is added

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P3)

Description

[Andy McKay]

When a new paid region is added to the marketplace we need to let developers of paid apps know this. For example, when we add in Seahorse, developers might need to add that in.

There are two scenarios:
* either a user has selected the "automatically add me to new regions" checkbox (http://cl.ly/image/2O0p0N211y3X) and so they are going to be automatically added for that app
* they haven't

In the former case, they should get an email letting them know they have been automatically added. In the latter case, they should get an email telling them to go to the devhub and update it.

Lets add these two scenarios to the existing admin email tool (see /admin/email-devs on your favorite zamboni instance).

http://cl.ly/image/472d3l2P3l3o

Comment 1

[Andy McKay]

Assigned to David, but hoping Stuart since he's in your timezone you can help out with all the questions he's going to have, mostly getting the query right.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Feel free to reuse this:
https://github.com/mozilla/zamboni/blob/b43d7a235/mkt/developers/cron.py#L18
https://github.com/mozilla/zamboni/blob/b43d7a235/mkt/developers/tasks.py#L569

Comment 3

[David Larlet [:davidbgk]]

If I understand correctly, the first case is already handled by the code pointed by Christopher and I have to adapt it for the particular case of developers who haven't checked the "automatically add me to new regions" checkbox. Dealing with new email templates asking those developers if they're sure not to be visible in the newly added region. Am I right?

(+ admin integration)

Comment 4

[[e-mail]]

Bear in mind that currently for paid apps the worldwide checkbox is currently disabled. I've added that bug to this as a dependency.

Comment 5

[Andy McKay]

FYI the email we are planning on sending looks like this:

https://etherpad.mozilla.org/payments-region-emails

Presuming this form can take some values like {{ app name }}.

Comment 6

[David Larlet [:davidbgk]]

Don't we make the distinction anymore with one/two/many regions added?

https://github.com/mozilla/zamboni/tree/master/mkt/developers/templates/developers/emails

Comment 7

[Andy McKay]

No idea what those templates are for tbh. The adding in of the payments for a region is a different action from adding in the region though.

Comment 8

[David Larlet [:davidbgk]]

These templates are in use within the region_email task:

https://github.com/mozilla/zamboni/blob/master/mkt/developers/tasks.py#L568

Isn't it what this bug is related to? To me we just have to distinguish between worldwide/local and thus update the templates accordingly as I partly did in:

https://github.com/davidbgk/zamboni/commit/40d4202779943dc0c7157ea19e6a34c567e88172#L4R0

Comment 9

[Andy McKay]

From etherpad: ./manage.py email_developers_about_new_paid_region <region_slug>

Comment 10

[Andy McKay]

You've got the management command in, is there anything else to do on this?

Comment 11

[David Larlet [:davidbgk]]

Reviewing https://github.com/mozilla/zamboni/pull/958

Comment 12

[David Larlet [:davidbgk]]

https://github.com/mozilla/zamboni/commit/db6f7f375c25ee367390fbcf285f2c018aed2ffd

Comment 13

[Iulian Timis]

Please add STR here or mark it with [qa-] if no QA is needed.