Closed
Bug 896053
Opened 11 years ago
Closed 11 years ago
nsCocoaWindow doesn't unlink child/sibling windows correctly
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: tnikkel, Assigned: tnikkel)
References
Details
(Whiteboard: [MemShrink:P2])
Attachments
(1 file)
|
1.61 KB,
patch
|
smichaud
:
review+
|
Details | Diff | Splinter Review |
nsCocoaWindow doesn't implement GetParent, so nsBaseWidget::Destroy never cleared the sibling list pointers for child widgets via the RemoveChild call. So we must have leaked a lot of windows. Until bug 869151 implemented it, but that caused the regression bug 891424. Bug 891424 should now be fixed, so we should be able to add back the RemoveChild call.
|
Assignee | |
Comment 1•11 years ago
|
||
I also fixed the comment up (oops).
Attachment #778668 -
Flags: review?(smichaud)
|
||
Updated•11 years ago
|
Attachment #778668 -
Flags: review?(smichaud) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
Not sure how much this actually causes us to leak given that it has gone unnoticed for many years. Anyways, the patch here can land now, but I'm giving it a few days so that beta and aurora have the same code as nightly in this case so we get as much testing as possible of bug 891424 and related.
|
||
Updated•11 years ago
|
Whiteboard: [MemShrink] → [MemShrink:P2]
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/65cd9cfc65c3
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/65cd9cfc65c3
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•