Introduce Togetherjs into thimble

RESOLVED FIXED

Status

Webmaker
Thimble
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: brett, Assigned: pomax)

Tracking

Details

(Whiteboard: s=20130729 p=1,mozfest)

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

5 years ago
I had an experience today with Pomax and FuzzyFox helping me with CSS.  It was great, and would be amazing if we shipped this exprience via towtruck.

Lets do it!
https://towtruck.mozillalabs.com/

Comment 1

5 years ago
+1 !!!!!!1111one eins uno
(Assignee)

Comment 2

5 years ago
<wex> Pomax: do this:
<wex> <script src="https://towtruck.mozillalabs.com/towtruck.js"></script>
<wex> <button onclick="TowTruck(this); return false;">Start TowTruck</button>
<brett> that would be a webmaker url
<wex> on any web page
<wex> you're mostly done
<Pomax> wex: sweet
<wex> actually do it htough
(Assignee)

Updated

5 years ago
Depends on: 894902
(Assignee)

Comment 3

5 years ago
mouse handling works well enough using the experimental towtruck instance on http://fast-river-3556.herokuapp.com, but typing doesn't seem to make it across, probably because codemirror is 2.x rather than 3.x -- we need to update to codemirror 3 anyway, so... good reason to!
(Assignee)

Updated

5 years ago
Whiteboard: s=2013w30
(Assignee)

Updated

5 years ago
Whiteboard: s=2013w30 → s=20130722
(Assignee)

Updated

5 years ago
Whiteboard: s=20130722 → s=20130722 p=1
(Assignee)

Comment 4

5 years ago
Never had that much fun.... https://bugzilla.mozilla.org/show_bug.cgi?id=894902 has been updated with a pull request for codemirror 3, and a new example .html file that includes towtruck. The result is amazingly collaboratively chaotic. And good.
(Assignee)

Comment 5

5 years ago
for SSO integration, TowTruck supports persona - http://towtruck.mozillalabs.com/example/app-integration.html
(Assignee)

Updated

5 years ago
Whiteboard: s=20130722 p=1 → s=20130729 p=1
(Assignee)

Comment 6

5 years ago
unassigning pending reprioritisation
Assignee: pomax → nobody
(Assignee)

Comment 7

5 years ago
my branch for this is at https://github.com/pomax/thimble.webmaker.org/tree/towtrucked
(Reporter)

Updated

5 years ago
Assignee: nobody → kieran.sedgwick
Whiteboard: s=20130729 p=1 → s=20130729 p=1,mozfest
(Assignee)

Comment 8

5 years ago
Created attachment 801811 [details]
https://github.com/pomax/thimble.webmaker.org/tree/towtrucked2

initial stab -- note that towtruck will be renamed "sometime this week" to togetherjs, so we can't actually land anything this week, even if we get the code perfected, simply because by next Monday it'll have a new name, and new repo.
Attachment #801811 - Flags: review?(kieran.sedgwick)
(Assignee)

Comment 9

5 years ago
tasks left:
- get mouse/keyboard events that happen while the content in the previewloader has focus, into towtruck
- signoff on labels for starting/stopping a session (currently: 'collaborate' and 'go it alone'. Open to better labels)
- a follow-up ticket that prevents certain things that lock up pages, like people adding while(true) loops or the like?
(Assignee)

Comment 10

5 years ago
Updated the pull request - the preview loader will now tell its own iframe that any mouse move and click events should be window.postMessage'd up to the preview-owning page. This uses a naive event relay, and may break on different sized browsers; the "click" is also cosmetic, not functional.

The real solution is to make towtuck run on the main page, and have a second towtruck session running (invisibly, local-only) in the preview iframe, and have this second session send all its from-the-iframe events to the main page for working into the session, then have it somehow send those events back into the preview sessions running locally for all people connected.

This is probably not something we can do for a first pass, and we might have to do a fair bit of work on towtruck itself to make that happen.

(also, at the time of this ticket update, there is a bug in towtruck that causes the collaborate button to spawn a second session, after having started the first. Clicking a third time actually closes the session. This is something that needs to be fixed in towtruck. In the mean time, sessions can be closed by clicking on the user icon and selecting "end session" in the towtruck tool bar)
(Assignee)

Comment 12

5 years ago
Created attachment 802656 [details]
https://github.com/Pomax/thimble.webmaker.org/compare/towtrucked2

compare view for the towtrucked2 branch.
Attachment #801811 - Attachment is obsolete: true
Attachment #801811 - Flags: review?(kieran.sedgwick)
Attachment #802656 - Flags: review?(kieran.sedgwick)
(Assignee)

Comment 14

5 years ago
nice, thanks Simon!
(Assignee)

Comment 15

5 years ago
name changed.
Summary: Introduce Tow Truck into thimble → Introduce Togetherjs into thimble
(Assignee)

Comment 16

5 years ago
Created attachment 811263 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/231

replaces the towtrucked branch, updated for the together.js naming
Attachment #802656 - Attachment is obsolete: true
Attachment #802656 - Flags: review?(kieran.sedgwick)
Attachment #811263 - Flags: review?(rick.eyre)

Comment 17

5 years ago
Comment on attachment 811263 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/231

Looks good to me.
Attachment #811263 - Flags: review?(rick.eyre) → review+
(Assignee)

Comment 18

5 years ago
Comment on attachment 811263 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/231

code review only, reyre's signed off on it working.
Attachment #811263 - Flags: review+ → review?(scott)
(Assignee)

Comment 20

5 years ago
Pushing to staging, however this might need a content/UX review in terms of "are we using the right labels" and "what font-awesome icon can we use for collaboration".
(Assignee)

Comment 21

5 years ago
Created attachment 811344 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/233

collab. icon -- http://i.imgur.com/9sGrUcq.png
Attachment #811344 - Flags: review?(david.humphrey)
Comment on attachment 811344 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/233

Let's start with this one, and see how we like it, and iterate if it's not good.  R+
Attachment #811344 - Flags: review?(david.humphrey) → review+
(Assignee)

Comment 23

5 years ago
it's in.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Comment 24

5 years ago
Lets mark as resolved when it's working on production :)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Updated

5 years ago
Assignee: kieran.sedgwick → pomax
(Assignee)

Comment 25

5 years ago
remarking as resolved, filing followups instead
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain text/plain → text/x-github-pull-request text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.