Closed Bug 896097 Opened 7 years ago Closed 7 years ago

Change - Remove on-screen buttons when auto-complete is visible

Categories

(Firefox for Metro Graveyard :: General, defect, P2)

x86
Windows 8.1
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 25

People

(Reporter: ywang, Assigned: mbrubeck)

References

Details

(Whiteboard: feature=change c=tbd u=tbd p=1)

Attachments

(1 file)

Once auto-complete screen is shown, the on-screen "back" and "plus" buttons should slide out.

Once the users quite auto-complete (by clicking "Close" or tapping outside of auto-complete), on-screen buttons should slide back.
Whiteboard: feature=change c=tbd u=tbd p=0
Priority: -- → P2
I'll take this.
Assignee: nobody → mbrubeck
Whiteboard: feature=change c=tbd u=tbd p=0 → feature=change c=tbd u=tbd p=1
Blocks: metrov1it11
No longer blocks: metrov1defect&change
Status: NEW → ASSIGNED
QA Contact: jbecerra
Attachment #781227 - Flags: review?(sfoster)
Comment on attachment 781227 [details] [diff] [review]
overlay-autocomplete

Review of attachment 781227 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, works well.
Attachment #781227 - Flags: review?(sfoster) → review+
Blocks: metrov1it12
No longer blocks: metrov1it11
https://hg.mozilla.org/mozilla-central/rev/bf035bca7f65
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130815030203
Built from http://hg.mozilla.org/mozilla-central/rev/a8daa428ccbc

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment0 and got expected result.
Went through the following "Change" for iteration #13 and found an issue. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-09-01-03-02-18-mozilla-central/

- Went through the original test case from comment #0 without any issues
- Dismissed the auto-search window by tapping on the website and the junior style buttons reappeared without any issues (ensured that they are working)
- Dismissed the auto-search window by tapping on the "X" (close) button and the junior style buttons reappeared without any issues (ensured that they are working)
- Ensured that the junior style buttons reappear after selecting a search result from the auto-search window (ensured that they are working)
- Went through all of the above test cases in filled view without any issues

Issues:

When the user slides the auto-search screen from view using the swipe gesture, the junior style buttons do not reappear. Created Bug 911530
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.