Escaped characters in popcorn maker descriptions

VERIFIED FIXED

Status

Webmaker
Popcorn Maker
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: brett, Assigned: mjschranz)

Tracking

Details

(Whiteboard: popbetter)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
See
https://dl.dropboxusercontent.com/u/7968133/images/tightpants.png

Jbuck you probably know where the culprit lies
(Reporter)

Updated

5 years ago
Whiteboard: popbetter

Comment 1

5 years ago
Also shows up for descriptions elsewhere on the site, i.e. the flipped homepage tile for Forrest's Eyebeam music video says:

Culmination of the Moving <img> Workshop at Eyebeam NYC. All of the activities: https://forresto.makes.org/thimble/moving-img-workshop

Possible this only happens for descriptions entered in Popcorn Maker, not Thimble.
(Assignee)

Updated

5 years ago
Assignee: jon → schranz.m
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Created attachment 790847 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/170

I think the right solution is to maintain the sanitization we do ourselves and just flag certain data as safe in nunjucks.
Attachment #790847 - Flags: review?(jon)

Comment 3

5 years ago
Comment on attachment 790847 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/170

Yeah, this should be okay
Attachment #790847 - Flags: review?(jon) → review+

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

5 years ago
Pushed to staging. Needs verification on prod.
Flags: needinfo?(schranz.m)
(Assignee)

Updated

5 years ago
Status: RESOLVED → VERIFIED
Flags: needinfo?(schranz.m)
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.