Closed
Bug 896147
Opened 11 years ago
Closed 11 years ago
/firefox/geolocation/ and /contact pages alerts user about needing a new Google Maps API key
Categories
(www.mozilla.org :: Pages & Content, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mconley, Assigned: pmac)
References
Details
(Whiteboard: [kb=1079155] r=119177)
Attachments
(1 file)
3.89 KB,
patch
|
agibson
:
review+
|
Details | Diff | Splinter Review |
STR: 1) Visit https://www.mozilla.org/en-US/firefox/geolocation/ 2) Wait for page to load AR: http://i.imgur.com/1rxfbWy.png ER: No alert dialog.
Comment 2•11 years ago
|
||
I cannot see the alert. The key is the same as the one used in https://www.mozilla.org/en-US/about/contact.html
Comment 4•11 years ago
|
||
I see the alert on https://www.mozilla.org/en-US/about/contact.html myself
Comment 5•11 years ago
|
||
I see the alert on https://www.mozilla.org/en-US/about/contact.html as well. (though not on http://www.mozilla.org/en-US/about/contact.html - note http: vs. https:)
Assignee | ||
Comment 6•11 years ago
|
||
I still can't reproduce, but this does seem to be an issue. I know we're in the process of replacing these maps with OSM, but we should fix this in the interim. Do we have an account from which we normally request such keys?
Flags: needinfo?(chrismore.bugzilla)
Comment 7•11 years ago
|
||
Paul not sure if this is helpful to you but I am also able to reproduce this.
Comment 8•11 years ago
|
||
I can reproduce it. I've asked IT before and they said to just register to get a new API key with your @mozilla.com email. This issue is that the api key we are using and the implementation is for version 2 and that was deprecated in 2010: https://developers.google.com/maps/signup We will have to get a new key from the API key console: https://developers.google.com/maps/documentation/javascript/v2/introduction#Obtaining_Key
Flags: needinfo?(chrismore.bugzilla)
Updated•11 years ago
|
Summary: https://www.mozilla.org/en-US/firefox/geolocation/ issues alert about needing a new Google Maps API key → /firefox/geolocation/ and /contact pages alerts user about needing a new Google Maps API key
Comment 9•11 years ago
|
||
Just FYI: I had patches for both page to use Google Maps API v3, if that's helpful https://github.com/mozilla/bedrock/commit/04a42cc90fc3a99c4207c0c85e0815e065120469 https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=767767&attachment=636136
Assignee | ||
Comment 11•11 years ago
|
||
Slight update to :hectorz's patch from the other bug he mentioned.
Attachment #790811 -
Flags: review?(bzhao)
Attachment #790811 -
Flags: review?(agibson)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → pmac
Updated•11 years ago
|
Whiteboard: [kb=1079155]
Comment 12•11 years ago
|
||
Comment on attachment 790811 [details] [diff] [review] gmaps-v3.patch Review of attachment 790811 [details] [diff] [review]: ----------------------------------------------------------------- I've ran this locally and the changes work as expected. There are some bits and pieces that could do with some tidying up in the mozilla-map.js, but these are not strictly related to this change. Seeing as this is a legacy page that will be ported to bedrock, and in the interests of getting this fixed - it looks ok to me.
Assignee | ||
Comment 13•11 years ago
|
||
(In reply to Alex Gibson [:agibson] from comment #12) Awesome. Filing request to update api key now. I'll block this bug w/ that one.
Assignee | ||
Comment 14•11 years ago
|
||
v3 key is in prod. Committed the patch in r119177.
Assignee | ||
Updated•11 years ago
|
Whiteboard: [kb=1079155] → [kb=1079155] r=119177
Assignee | ||
Comment 15•11 years ago
|
||
Pushed to prod in r119179.
Comment 16•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/c17f9c8ea2112090991cd4e1eb68f6309771a73f Bug 896147: migrate geolocation demo to google maps api v3 https://github.com/mozilla/bedrock/commit/87a227ab08c4f32a1f52d04253920b9c7466ca11 Merge pull request #1171 from l-hedgehog/bug-896147-google-maps-api-v3 Bug 896147: migrate geolocation demo to google maps api v3
Verified FIXED on https://www.mozilla.org/en-US/about/contact.html and https://www.mozilla.org/en-US/firefox/geolocation/
Assignee | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Verified (see comment 17).
Status: RESOLVED → VERIFIED
Comment 19•11 years ago
|
||
Comment on attachment 790811 [details] [diff] [review] gmaps-v3.patch Clear the review request as this is already in production
Attachment #790811 -
Flags: review?(bzhao)
Updated•11 years ago
|
Attachment #790811 -
Flags: review?(agibson) → review-
Updated•11 years ago
|
Attachment #790811 -
Flags: review- → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•