/firefox/geolocation/ and /contact pages alerts user about needing a new Google Maps API key

VERIFIED FIXED

Status

VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: mconley, Assigned: pmac)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kb=1079155] r=119177)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
STR:

1) Visit https://www.mozilla.org/en-US/firefox/geolocation/
2) Wait for page to load

AR:

http://i.imgur.com/1rxfbWy.png

ER:

No alert dialog.
Duplicate of this bug: 896530
I cannot see the alert. The key is the same as the one used in
https://www.mozilla.org/en-US/about/contact.html

Updated

5 years ago
Duplicate of this bug: 903697

Comment 4

5 years ago
I see the alert on https://www.mozilla.org/en-US/about/contact.html myself
I see the alert on https://www.mozilla.org/en-US/about/contact.html as well.

(though not on http://www.mozilla.org/en-US/about/contact.html - note http: vs. https:)
I still can't reproduce, but this does seem to be an issue. I know we're in the process of replacing these maps with OSM, but we should fix this in the interim. Do we have an account from which we normally request such keys?
Flags: needinfo?(chrismore.bugzilla)
Paul not sure if this is helpful to you but I am also able to reproduce this.

Comment 8

5 years ago
I can reproduce it. I've asked IT before and they said to just register to get a new API key with your @mozilla.com email. This issue is that the api key we are using and the implementation is for version 2 and that was deprecated in 2010:

https://developers.google.com/maps/signup

We will have to get a new key from the API key console:

https://developers.google.com/maps/documentation/javascript/v2/introduction#Obtaining_Key
Flags: needinfo?(chrismore.bugzilla)

Updated

5 years ago
Summary: https://www.mozilla.org/en-US/firefox/geolocation/ issues alert about needing a new Google Maps API key → /firefox/geolocation/ and /contact pages alerts user about needing a new Google Maps API key

Updated

5 years ago
Duplicate of this bug: 905108
Created attachment 790811 [details] [diff] [review]
gmaps-v3.patch

Slight update to :hectorz's patch from the other bug he mentioned.
Attachment #790811 - Flags: review?(bzhao)
Attachment #790811 - Flags: review?(agibson)
Assignee: nobody → pmac

Updated

5 years ago
Whiteboard: [kb=1079155]

Updated

5 years ago
Blocks: 905674
Comment on attachment 790811 [details] [diff] [review]
gmaps-v3.patch

Review of attachment 790811 [details] [diff] [review]:
-----------------------------------------------------------------

I've ran this locally and the changes work as expected.

There are some bits and pieces that could do with some tidying up in the mozilla-map.js, but these are not strictly related to this change. Seeing as this is a legacy page that will be ported to bedrock, and in the interests of getting this fixed - it looks ok to me.
(In reply to Alex Gibson [:agibson] from comment #12)
Awesome. Filing request to update api key now. I'll block this bug w/ that one.
Depends on: 906084
v3 key is in prod. Committed the patch in r119177.
Whiteboard: [kb=1079155] → [kb=1079155] r=119177
Pushed to prod in r119179.

Comment 16

5 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/c17f9c8ea2112090991cd4e1eb68f6309771a73f
Bug 896147: migrate geolocation demo to google maps api v3

https://github.com/mozilla/bedrock/commit/87a227ab08c4f32a1f52d04253920b9c7466ca11
Merge pull request #1171 from l-hedgehog/bug-896147-google-maps-api-v3

Bug 896147: migrate geolocation demo to google maps api v3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Verified (see comment 17).
Status: RESOLVED → VERIFIED
Comment on attachment 790811 [details] [diff] [review]
gmaps-v3.patch

Clear the review request as this is already in production
Attachment #790811 - Flags: review?(bzhao)

Updated

5 years ago
Attachment #790811 - Flags: review?(agibson) → review-

Updated

5 years ago
Attachment #790811 - Flags: review- → review+

Updated

5 years ago
Duplicate of this bug: 911817
You need to log in before you can comment on or make changes to this bug.