Closed Bug 896256 Opened 7 years ago Closed 6 years ago
GCLI: fix hard-coded Firefox and en-US link in cmd
http://hg.mozilla.org/mozilla-central/diff/0ebbdfbb31eb/browser/locales/en-US/chrome/browser/devtools/gclicommands.properties cmdSetdirManual=A 'mozcmd' directory is an easy way to create new custom commands for the Firefox command line. For more information see the <a href="https://developer.mozilla.org/en-US/docs/Tools/GCLI/Customization">MDN documentation</a>. I think there are two problems with this string. 1. Don't hard code "Firefox" (see bug 812762). 2. Don't hard-code en-US in links to MDN or SUMO, let the platform do its magic with locale redirection. Correct link: https://developer.mozilla.org/docs/Tools/GCLI/Customization Also another doubt from a non-native English speaker. Doesn't this sound wrong? cmdStatus=Read %1$S commands from '%2$S' I think the meaning is "%1$S commands have been read from '%2$S'", like this it sound like a command.
Perhaps also give some info in the empty l10n notes for cmdSetdirDesc and cmdSetdirManual, or remove them?
Joe, are these strings actually used in the product? I can't find any reference in the code, but these two strings are definitely still there.
6 years ago
Assignee: nobody → jwalker
6 years ago
Comment on attachment 8435004 [details] [diff] [review] 0004-Bug-896256-Fix-l10n-for-a-number-of-strings-in-the-G.patch Review of attachment 8435004 [details] [diff] [review]: ----------------------------------------------------------------- r+ with nits addressed ::: browser/locales/en-US/chrome/browser/devtools/gclicommands.properties @@ +581,2 @@ > > # LOCALIZATION NOTE (cmdStatus2) When the we load new commands from mozcmd cmdStatus3 @@ +589,3 @@ > cmdSetdirDesc=Setup a mozcmd directory > > +# LOCALIZATION NOTE (cmdSetdirManual) A fuller description of the 'cmd setdir' cmdSetdirManual2
Attachment #8435004 - Flags: review?(mratcliffe) → review+
Thanks for the review
Attachment #8435004 - Attachment is obsolete: true
Green try: https://tbpl.mozilla.org/?tree=Try&rev=eded224de172 (problems on earlier patch were unrelated) Landing: https://tbpl.mozilla.org/?tree=Fx-Team&rev=98c8ea754cb4 https://hg.mozilla.org/integration/fx-team/rev/98c8ea754cb4
Landing hash is actually: https://hg.mozilla.org/integration/fx-team/rev/ee73aa7a855c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
You need to log in before you can comment on or make changes to this bug.