896275 - Use MOZ_THIS_IN_INITIALIZER_LIST in dom/

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Sorry about the includes; I wrote this before you suggested avoiding them.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/dc2f8b382241

Comment 2

[Tatiana Meshkova (:tatiana)]

Is it necessary to move MOZ_WIDGET_ includes down? See 898311.

Comment 3

[Jan Varga [:janv]]

man, why did you change all those includes ?

Comment 4

[Mounir Lamouri (:mounir)]

(In reply to Jan Varga [:janv] from comment #3)
> man, why did you change all those includes ?

He has a tool reordering the #include in some kind of alphabetical order IIRC.

Comment 5

[Jan Varga [:janv]]

(In reply to Mounir Lamouri (:mounir) from comment #4)
> (In reply to Jan Varga [:janv] from comment #3)
> > man, why did you change all those includes ?
> 
> He has a tool reordering the #include in some kind of alphabetical order
> IIRC.

So, is this the official style/scheme that we should try to follow ?

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Yep, see https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style#C.2FC.2B.2B_practices