896303 - Media Recording - Calling start on a MediaRecorder object with no parameters results in ondataavailable events firing, even though they shouldn't be

Status: VERIFIED FIXED

(Core :: Audio/Video: Recording, defect)

Description

[Jason Smith [:jsmith]]

STR

1. Load https://bug891722.bugzilla.mozilla.org/attachment.cgi?id=773094 in Nightly
2. In the console, type mediaRecorder.start();
3. Wait a few seconds

Expected

No ondataavailable events should fire.

Actual

ondataavailable events fire every couple of seconds.

Comment 1

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: patch v1

Test case can be:
Call the start() function and check if can invoke the requestData() to get the blob data.

Comment 2

[Jason Smith [:jsmith]]

Bonus points btw for a mochitest here.

Comment 3

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

We can have a common js to get the mediaStream from variety source. :)

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 779846 [details] [diff] [review]
patch v1

Review of attachment 779846 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/MediaRecorder.cpp
@@ +146,5 @@
>      for (uint i = 0; i < outputBufs.Length(); i++) {
>        mEncodedBufferCache->AppendBuffer(outputBufs[i]);
>      }
>  
> +    if ((TimeStamp::Now() - lastBlobTimeStamp).ToMilliseconds() > mTimeSlice && mTimeSlice > 0) {

Check mTimeSlice > 0 first, since the call to Now() is slightly expensive.

Comment 5

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: check-in patch

check-in patch.
Hi Jason, Could you also cover this test case?

Comment 6

[Jason Smith [:jsmith]]

(In reply to Randy Lin [:rlin] from comment #5)
> Created attachment 780289 [details] [diff] [review]
> check-in patch
> 
> check-in patch.
> Hi Jason, Could you also cover this test case?

Sure, I can cover it.

Comment 7

[Jason Smith [:jsmith]]

FYI - checkin-needed is a keyword, not a whiteboard tag.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/projects/birch/rev/4cdfb15c711e

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4cdfb15c711e

Comment 10

[Jason Smith [:jsmith]]

Verified on trunk - no parameters is correctly not firing ondataavailable events by default. Only requestData and calling stop invokes the ondataavailable event to fire. Also regression tested start with parameters as well to ensure it still works.

Comment 11

[Jason Smith [:jsmith]]

Tracking development of mochitest in bug 899878.