Closed
Bug 896347
Opened 12 years ago
Closed 12 years ago
typo of apps@1.5x /@2x assets
Categories
(Firefox OS Graveyard :: Gaia::Camera, defect)
Tracking
(b2g18 fixed, b2g-v1.1hd fixed)
RESOLVED
FIXED
People
(Reporter: gasolin, Assigned: gasolin)
Details
Attachments
(2 files)
running script to matching files, found typo of `video_play_normal@2.png`, should be `video_play_normal@2x.png`
Assignee | ||
Updated•12 years ago
|
blocking-b2g: --- → hd?
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → gasolin
Assignee | ||
Updated•12 years ago
|
Summary: typo of @2x asset for Camera app → typo of @1.5x/@2x asset for apps
Assignee | ||
Updated•12 years ago
|
Summary: typo of @1.5x/@2x asset for apps → typo of apps@1.5x/@2x assets
Assignee | ||
Comment 1•12 years ago
|
||
another typo `ions/dialer/style/images/calllog_editlist@1.5.png `,
should be `ions/dialer/style/images/calllog_editlist@1.5x.png `
Assignee | ||
Comment 2•12 years ago
|
||
find typo by running script (the script will be public soon)
Attachment #779088 -
Flags: review?(rexboy)
Assignee | ||
Comment 3•12 years ago
|
||
Script to gather gaia multiple resolution resources to a web page for easy debugging https://gist.github.com/gasolin/6052727
Comment 4•12 years ago
|
||
Comment on attachment 779088 [details]
pull request redirect to github
Thanks for your great tools.
I'm thinking whether we can perform such kind of asset check on git commit... Just like our linter check and travis
Attachment #779088 -
Flags: review?(rexboy) → review+
Assignee | ||
Comment 5•12 years ago
|
||
merged in master-gaia https://github.com/mozilla-b2g/gaia/commit/f8fb47df980912691441694f1b7579893e7eb3b4
thanks!
status-b2g18:
--- → fixed
status-b2g-v1.1hd:
--- → affected
Assignee | ||
Comment 6•12 years ago
|
||
Need to add another PR for HD, since 2x image does not exist in HD branch
Attachment #779648 -
Flags: review?(rexboy)
Updated•12 years ago
|
Attachment #779648 -
Flags: review?(rexboy) → review+
Assignee | ||
Comment 7•12 years ago
|
||
merged to hd https://github.com/mozilla-b2g/gaia/commit/624a607b1d4ad1bbefa0b7efb4e7b0151052421f
thanks!
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 8•11 years ago
|
||
Mass-modify - removal of no longer relevant blocking flags.
Updated•11 years ago
|
blocking-b2g: hd? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•