896351 - [B2G][Helix][dialer]Phonebook match digits(11/7) do not work.

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[wangchao]

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E; Tablet PC 2.0)

Steps to reproduce:

Contacts has a record: Name: Toy, Tel: [phone]

In dialer: I dialed 1001202(the last 7 digits of Toy's tel), and call. It can not match to Toy, just call out as 1001202.

As I tried, if i dialed  01001202(the last 8 digits of Toy's tel), it can match to Toy, but this is not satisfied in Mexico, in Mexico it required 7 digits to match.

Thanks!

Comment 1

[Wayne Chang [:wchang]]

Hi Yuren,

I believe the number of digits used to match contacts can differ depend on the country as implemented in https://bugzilla.mozilla.org/show_bug.cgi?id=877302.

Can you check if that bug covers this and all we need to do is add Mexico = 7?

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Rex may answer this question, ni? rex.

Comment 3

[wangchao]

As we talked, could you supply the method to configure number match?

How to add a country mcc and set the length of match digits.

Thanks!

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

I'm not involved in this issue, Gregor may you confirm on this?
Thanks for your help.

Comment 5

[wangchao]

I hava met a problem, when init, it failed to get mcc along with network or sim.

You can see the details in attachment(by match "w00221726").

I have done some analysis.

//in ContactService.jsm
this.DOMContactManager = {      
  init: function() 
  {}
}

in function init(), it goes to get the mcc and then fetch the length of match digits.

But at this moment, network and sim card is not ready, so try to get the mcc failed, it just use the default mcc:724.

And then set: //in ContactDb.jsm
this.substringMatching = aDigits;  //for BR, it was 7, setting in b2g.js

So "this.substringMatching" get a wrong value. 

Thanks!

Comment 6

[wangchao]

Attachment: number match.txt

add log for the failed to get mcc when init.

Comment 7

[wangchao]

//for BR, it was 8, setting in b2g.js
change 7 -> 8

Comment 8

[Gregor Wagner [:gwagner]]

We still have to fix bug 890909.

Comment 9

[Julien Wajsberg [:julienw]]

Gregor, if this bug is fixed in bug 890909 (which I think it is) this should be a duplicate, right ?

Comment 10

[Michael Henretty [:mikehenrty][:mhenretty]]

What build of gecko is this running against? Bug 890909 is fixed in m-c, but not in Leo builds yet. If this is only happening in Leo then it is indeed a duplicate.

Comment 11

[wangchao]

The build id is v1.1.0hd.

Comment 12

[Michael Henretty [:mikehenrty][:mhenretty]]

Wangchao,

The fix from bug 890909 landed today (https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/8135299f3efd), can you test again to see if this is fixed?

Comment 13

[wangchao]

I've update to the newest version, but the problem is still exist.

It still can not get the mcc.

You can see the details from the log.

Thanks!

Comment 14

[wangchao]

Attachment: number_match_for new ver.txt

Comment 15

[Julien Wajsberg [:julienw]]

wangchao, I don't see the line where the match should happen.

Or is it :

08-05 02:50:49.159 I/Gecko   (  163): -*- ContactDB component: creating cache for query {"sortBy":"givenName","sortOrder":"ascending"}^M
08-05 02:50:49.159 I/Gecko   (  163): -*- ContactDB component: ContactDB:find val:undefined by: undefined op: undefined^M
08-05 02:50:49.159 I/Gecko   (  163): -*- ContactDB component: ContactDB:_findAll:  {"sortBy":"givenName","sortOrder":"ascending"}^M
08-05 02:50:49.169 I/Gecko   (  163): -*- ContactDB component: Request successful. Record count:0^M
08-05 02:50:49.169 I/Gecko   (  163): -*- ContactDB component: query returned no contacts^M

What's strange with this log is that the input values seem to be undefined ?


(note: The next time it would help to "grep Gecko" or "grep Contact" in your log)

Comment 16

[Gregor Wagner [:gwagner]]

(In reply to Wayne Chang [:wchang] from comment #1)
> Hi Yuren,
> 
> I believe the number of digits used to match contacts can differ depend on
> the country as implemented in
> https://bugzilla.mozilla.org/show_bug.cgi?id=877302.
> 
> Can you check if that bug covers this and all we need to do is add Mexico =
> 7?

Do we need to match 7 digits for Mexico?

Comment 17

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Gregor Wagner [:gwagner] from comment #16)
> > Can you check if that bug covers this and all we need to do is add Mexico =
> > 7?
> 
> Do we need to match 7 digits for Mexico?

I looks like wangchao has a sim card from Spain, and we don't have a sim for either Spain or Mexico. Should we add one for Mexico?

08-05 02:47:57.699 I/Gecko   (  163): -*- QCContentHelper_QC_B2G: sendMessage to content process: RIL:IccInfoChanged{ iccid : null, mcc : '214', mnc : '07',....


Judging by his recent logs, something fishy is going on. I don't see us updating the substring matching value after we send the SIM change event, so it should still erroneously bet set to the default Brazil which has a value of 7. This should make the bug appear fixed. I'm investigating this now.

Comment 18

[wangchao]

I have add 214 for spain in b2g.js.
pref("dom.phonenumber.substringmatching.ES", 9);  //for test

But it does not work.

The point is it did not get the correct mcc.

Thanks!

Comment 19

[Gregor Wagner [:gwagner]]

(In reply to wangchao from comment #18)
> I have add 214 for spain in b2g.js.
> pref("dom.phonenumber.substringmatching.ES", 9);  //for test
> 
> But it does not work.
> 
> The point is it did not get the correct mcc.
> 
> Thanks!

Please provide your exact steps how you tested this.
What sim card do you have in your device? Where is your location?
Did you add the contact after you made your pref change? What were the numbers you tested?

Comment 20

[Wayne Chang [:wchang]]

Sorry my comment was based on comment 0 description, assuming they got this request correct.

(In reply to Gregor Wagner [:gwagner] from comment #16)
> (In reply to Wayne Chang [:wchang] from comment #1)
> > Hi Yuren,
> > 
> > I believe the number of digits used to match contacts can differ depend on
> > the country as implemented in
> > https://bugzilla.mozilla.org/show_bug.cgi?id=877302.
> > 
> > Can you check if that bug covers this and all we need to do is add Mexico =
> > 7?
> 
> Do we need to match 7 digits for Mexico?

Comment 21

[wangchao]

(In reply to Gregor Wagner [:gwagner] from comment #19)
> (In reply to wangchao from comment #18)
> I have add 214 for spain in
> b2g.js.
> pref("dom.phonenumber.substringmatching.ES", 9);  //for test
> 
>
> But it does not work.
> 
> The point is it did not get the correct mcc.
> 
>
> Thanks!

Please provide your exact steps how you tested this.
What sim card
> do you have in your device? Where is your location?
Did you add the contact
> after you made your pref change? What were the numbers you tested?


in b2g.js, add:
pref("dom.phonenumber.substringmatching.CN", 10);  //for test
pref("dom.phonenumber.substringmatching.ES", 9);  //for test

our test network mcc= 460;
my test sim card mcc=214, but this card is opened in test network.

As i read the log, mcc = undefined. It failed to get mcc.

Thanks!

Comment 22

[Doug Sherk (:drs) (inactive)]

This bug is out of date and we suspect that it's no longer valid. If you think this is in error, please reopen it.