896354 - [STK] cannot operate timer for get_input, get_inkey

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[Leo]

Attachment: icc.js (system) -> before and after file

When we take a test for STK, we found some problem. 
As you know, inputtimeout value is defined in icc.js(system app). But, input function do not operate for input timer. Although this function receive timer value as parameter(timeout), it does not use that and only initialize timeoutId value. Therefore I add some code for timer. when I take a test, timer is operated very well. 

However, there is some side effect. 
1. keyboroard does not disappear, although timer finish.(40 seconds)
2. If user push soft key,inputbox is located in foreground and idle screen is located in background.  

So, plz reveiw my code and fix this problem. 
(it already attached before & after file)

Comment 1

[bhavana bajaj [:bajaj]]

needsinfo, fernando here to help with some investigation here to understand if this is a fallout from 1.1 STK refactoring

Comment 2

[bhavana bajaj [:bajaj]]

Switching the needinfo to the right Fernando :|

Comment 3

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Could be, I'll study it

Comment 4

[Preeti Raghunath(:Preeti)]

hi,

Any inputs on the STK refactoring fall outs?

Comment 5

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Added timeout on STK input boxes

Comment 6

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Preeti Raghunath(:Preeti) from comment #4)
> hi,
> 
> Any inputs on the STK refactoring fall outs?

I just uploaded a PR. Check if this fixes the issue.

Comment 7

[Leo]

Today,I have confirmed by adding your code. 
It is operated properly. But, I think that it cannot operated completely. 

1. go to  stk menu -> execute get input
2. display input box -> enter some character 

--> when user didn't enter character or string, get input pop-up is disappear and go to stk root menu. but user enter some character or string, get input pop-up is not disppear. 
plz refer attached log file.

Comment 8

[Leo]

Attachment: log file

Comment 9

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Leo from comment #7)
> Today,I have confirmed by adding your code. 
> It is operated properly. But, I think that it cannot operated completely. 
> 
> 1. go to  stk menu -> execute get input
> 2. display input box -> enter some character 
> 
> --> when user didn't enter character or string, get input pop-up is
> disappear and go to stk root menu. but user enter some character or string,
> get input pop-up is not disppear. 
> plz refer attached log file.

Nice to hear is working now :)

Regarding the second use case, I implemented in this way since if no user interaction the dialog will be closed but if the user starts an interaction with the dialog and it's closed is not a normal behaviour.

The other alternative is to restart the timer each time the user press a key but I don't think this should be the correct way of working.

WDYT?

Comment 10

[Leo]

Dear, Fernando 

When I compared with android model by using same usim card, get inkey, get input timer timer is operated. And It is closed, when timer is finished.
Therefore, I agree with your second alternative. (restart timer,  when each time the user user press a key.)

If It is possible to change source, plz do that.

Comment 11

[Leo]

When I confirmed android model by using same usim card, get inkey, get input timer is operated normally, although user enter the key. 
Therefore I agree with your second opinion(restarting the timer each time the user press a key)
If it is possible to change the way which start get input, get input timer, please do that. 

Thank you

Comment 12

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Leo from comment #10)

> If It is possible to change source, plz do that.

Done !

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 787339 [details]
Added timeout on STK input boxes

Thanks for fixing the logical error.

Comment 15

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Thanks Tim.

Landed: https://github.com/mozilla-b2g/gaia/commit/a3efcbd1f83943b32b43a1738454efcd11f7202c