896368 - Follow up to bug882593 [SMS/MMS] When tapping on a contact added into 'To' field, the picture is not shown

Status: RESOLVED DUPLICATE of bug 924475

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[isabelrios]

Unagi device v1-train 07/21 build:
Gecko-1fc50aa
Gaia-c4bdd32
ref ril

STR
1. Open Messaging app and create a message
2. Select a contact with picture to add into 'To' field
3. Once added, tap on it.

EXPECTED
According to latest doc: HTML5_SMS-MMSUserStorySpecifications_20130503_V8.0, on pag#16 -> Step 5., on the contact details view, the picture should also be shown.

ACTUAL
Contact info is shown ok but the picture is missing.

Marking as leo? as it is a follow up of a leo+ bug.

Comment 1

[Fernando Campo (:fcampo)]

After speaking with Borja and checking open bugs, we found a clash with bug 882154, where the new visuals for the prompt shows no image for the contact. I'm blocking this till it's resolved and comment in the other bug

Comment 2

[Alex Keybl [:akeybl]]

Not clear why this should be a blocker at this late point in the release. We can always fix in 1.2.

Comment 3

[Borja Salguero [:borjasalguero]]

Victoria, for adding this feature we need your help here! Visual specs does not include the picture (check https://bug882154.bugzilla.mozilla.org/attachment.cgi?id=767098 ), so probably we need to update this for adding this info.

Comment 4

[Silviaf]

Attachment: Visual specs showing an overlay with a contact and photograph

Visual specs attached.

Comment 5

[Julien Wajsberg [:julienw]]

see bug 873498: Victoria actually asked us to remove the picture at one point.

Comment 6

[Victoria Gerchinhoren [:vicky]]

Hi Julien, 
There seems to be a confusion here, they are different cases. The bug 873498 talks about the contacts suggestions when composing an SMS, which should be a very light, fast "autocomplete" kind of situation, while this is the Contacts information overlay. Even though I don't buy completley the idea of pictures in overlays, for the sake of consistency, and after designing other screens where contact information is crucial, like merging contacts, where we used photos in order to help recognize duplicates, the picture would be valid.

Sorry for the confusion, let's have the photo.

Thanks! Victoria

(In reply to Julien Wajsberg [:julienw] from comment #5)
> see bug 873498: Victoria actually asked us to remove the picture at one
> point.

Comment 7

[Julien Wajsberg [:julienw]]

oki, I get it, and now it's clearer :)

thanks all!

Comment 8

[Joe Cheng [:jcheng] (please needinfo)]

add to backlog 891754

Comment 9

[Julien Wajsberg [:julienw]]

Fernando, I'm removing you as assignee here, but feel free to assign back if you think you can work on this.

This is a moderately difficult good first bug.

Comment 10

[at-kitamura]

Hi Julien-san,

I try this bug with Kobayashi-san.
This bug is going to be able to advance with bug 890209.
Please assign to me.

Comment 11

[Julien Wajsberg [:julienw]]

Hi Kitamura-san, 

I'll dupe this bug to bug 924475, because there is more work needed in this panel, and I'd like that only one person work on this.