896413 - dnsmasq is not deleted when wifi hotspot is turned off

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Comment 1

[Vincent Chang[:vchang][changyihsin]]

Dnsmasq is acted as dhcp server and dns forwarder when turn on Wifi hotspot, it should be deleted when Wifi/USB hotspot is turned off. 

The root cause of this bug is because the parse error of "interface list 0" netd command when there is no tethering interface.

Comment 2

[Vincent Chang[:vchang][changyihsin]]

We can check this bug from "adb shell ps" command. 
When Wifi hotspot is turned on, 
wifi      532   110   2240   904   c013bfe4 400dd8d4 S /system/bin/hostapd
root      536   110   1000   424   c013bfe4 400128d4 S /system/bin/dnsmasq

When Wifi hotspot is turned off, these two processes should be deleted.

Comment 3

[Vincent Chang[:vchang][changyihsin]]

Attachment: Patch v1.0 for mc

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 779153 [details] [diff] [review]
Patch v1.0 for mc

Review of attachment 779153 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/net_worker.js
@@ +50,5 @@
>  // Broadcast messages
>  const NETD_COMMAND_INTERFACE_CHANGE     = 600;
>  const NETD_COMMAND_BANDWIDTH_CONTROLLER = 601;
>  
> +const INTERFACE_DELIMIT = ":";

Why not use "\0" to be sure that we won't run into this again?

Comment 5

[Vincent Chang[:vchang][changyihsin]]

(In reply to Blake Kaplan (:mrbkap) from comment #4)
> Comment on attachment 779153 [details] [diff] [review]
> Patch v1.0 for mc
> 
> Review of attachment 779153 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/system/gonk/net_worker.js
> @@ +50,5 @@
> >  // Broadcast messages
> >  const NETD_COMMAND_INTERFACE_CHANGE     = 600;
> >  const NETD_COMMAND_BANDWIDTH_CONTROLLER = 601;
> >  
> > +const INTERFACE_DELIMIT = ":";
> 
> Why not use "\0" to be sure that we won't run into this again?

Good idea, thank you.

Comment 6

[Vincent Chang[:vchang][changyihsin]]

Attachment: Patch v1.1 for mc

Update the patch to address review comment.

Comment 7

[Vincent Chang[:vchang][changyihsin]]

Push to birch. 
https://hg.mozilla.org/projects/birch/rev/3a6a6098c764

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3a6a6098c764

Comment 9

[Vincent Chang[:vchang][changyihsin]]

We also need to land this patch to b2g18 because it blocks bug 894737 which is marked as leo+. 

Nominate it for leo.

Comment 10

[Vincent Chang[:vchang][changyihsin]]

I just realized that bug Bug 787442 is not landed in b2g18. 
So cancel the leo?