Classic: "Choose File" button is missing in Composer's Image Properties dialog

VERIFIED FIXED in mozilla0.9.3

Status

()

--
major
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: cmanske, Assigned: cmanske)

Tracking

Trunk
mozilla0.9.3
x86
Windows NT
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed, nsBranch+, PDT+)

Attachments

(3 attachments)

(Assignee)

Description

17 years ago
The first time you try to insert an image in Composer, the Image dialog doesn't
display the "Choose File" button. This is actually an XPFE problem with grids
(Bug 67333), but that won't be fixed for 6.1.
This seems to be a problem only in Classic skin. Simply adding 'flex="1"' seems
to fix the problem.
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Depends on: 67333
Target Milestone: --- → mozilla0.9.3
(Assignee)

Comment 1

17 years ago
Created attachment 41432 [details] [diff] [review]
Fix missing button
(Assignee)

Updated

17 years ago
Keywords: patch, review
Whiteboard: FIX IN HAND, need r=, sr=

Comment 2

17 years ago
manager reviewed the need for the fix and agrees, approval for checkin to the
trunk and branch after fix has received an r= and sr=, adding nsBranch keyword
Keywords: nsBranch

Comment 3

17 years ago
sigh
r=brade
Whiteboard: FIX IN HAND, need r=, sr= → FIX IN HAND, need sr=
(Assignee)

Comment 4

17 years ago
Identical problem of a missing widget (a menulist) occurs in the Table Properties
dialog. Exactly the same solution: add "flex" to the grid column.
(Assignee)

Comment 5

17 years ago
Created attachment 41441 [details] [diff] [review]
Updated patch to also fix Table Properties dialog

Comment 6

17 years ago
sr=sfraser

We need to file a bug on the XUL guys about this problem, if one does not exist 
already.
(Assignee)

Comment 7

17 years ago
Checked in.
Keywords: patch, review → vtrunk
Whiteboard: FIX IN HAND, need sr= → FIX IN HAND

Comment 8

17 years ago
bae
Whiteboard: FIX IN HAND → fixed, nsBranch+

Updated

17 years ago
Whiteboard: fixed, nsBranch+ → fixed, nsBranch+, PDT+

Comment 9

17 years ago
per discussion with selmer, adding PDT+
(Assignee)

Comment 10

17 years ago
Fixes have been checked into both trunk and branch, but there's still problems
with displaying 2 menulists in the Table Properties dialog, the menulists to the
right of the "Vertical" and "Horizontal" checkboxes in the "Content Alignment"
groupbox. The way things currently stand, when this dialog is first launched,
the menulists appear but do not show the current value. The menulists can be 
used to select a value, but still do not show the selected value.
Note that as discussed above, the real bug is an XPFE layout issue with grids,
so I'm continuing to investigate this problem with XPFE engineers.
The current checkin state is acceptable for RTM, but we would like to fix it 
completely if possible.
(Assignee)

Comment 11

17 years ago
Created attachment 41972 [details] [diff] [review]
Fixes all of the missing menulists
(Assignee)

Comment 12

17 years ago
We are still dealing with kludges, but the 7/11 patch fixes all of the 
missing menulist problems in the Table Properties dialog.

Comment 13

17 years ago
r/sr=sfraser

Comment 15

17 years ago
Okay on trunk, the Classic image choose file button is now fine,

but now look at the modern skin choose file button! that is messed
up.

Keywords: vtrunk
(Assignee)

Comment 16

17 years ago
This is now fixed. The "Choose file" button in the Image Properties sometimes
doesn't look perfect when dialog is first loaded (right edge is choped off and
doesn't have proper border), but we will have to live with that until 
the real problem, bug 67333, is fixed.
I'll be sure to follow through on this issue for 1.0.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 17

17 years ago
verified in 7/13 branch build for windows.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.