896526 - Permissions should work for apps launched directly in Firefox tabs

Status: RESOLVED DUPLICATE of bug 930104

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kevin Grandon :kgrandon]

When we run gaia inside of a browser we install permissions, but these permissions only work if you launch the app from the system app. Ideally we would be able to launch apps inside of tabs and the permissions would take effect.

Comment 1

[Kevin Grandon :kgrandon]

Some possible options: 

1 - Replace the xul browser with a mozbrowser dynamically if we detect that we're loading an app. Seems like this would be fairly tricky to implement.
2 - Proxy the app by loading an <iframe mozbrowser> in an empty page. This raises questions about if we should support app loading by opening new tabs.
3 - Give out permissions to domains as well as apps.

At this time the giving permissions to the domains as well as apps seems like the easiest solution.

Comment 2

[Kevin Grandon :kgrandon]

Attachment: github-pull-request-pointer.html

This is probably the easiest fix for the time being. This will make it so that we also install permissions for manifests.

I feel that the more correct fix would be to swap out the xul browser for a mozbrowser on the fly.

Comment 3

[Kevin Grandon :kgrandon]

After chatting on IRC with Fabrice, a better approach might be to load a <mozbrowser> over a custom gaia protocol.

We should take a look at that, but I won't have time to investigate this week.

Comment 4

[[:fabrice] Fabrice Desré]

I tried to load the iframe using a simple data: uri, like:

data:text/html;charset=utf-8,<iframe style="width: 320px; height:480px" mozapp="http://settings.gaiamobile.org:8080/manifest.webapp" src="http://settings.gaiamobile.org:8080/index.html"></iframe>

The app is displayed as expected, but no permissions are set :(

Comment 5

[Kevin Grandon :kgrandon]

Hi Fabrice, perhaps you also need to add mozbrowser="true"?

Comment 6

[[:fabrice] Fabrice Desré]

(In reply to Kevin Grandon :kgrandon from comment #5)
> Hi Fabrice, perhaps you also need to add mozbrowser="true"?

That doesn't work either with mozborwser :(

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 779248 [details]
github-pull-request-pointer.html

Hi Fabrice - 

Getting time to work on a better solution for the time-being is tough. I'd personally like to land this patch as-is for now, and we can keep a bug open to find a better replacement in the near future.

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 779248 [details]
github-pull-request-pointer.html

Webapps have changed recently and I think a new approach is needed. Also we should try to simplify the approach if possible.

Comment 9

[Kevin Grandon :kgrandon]

Very excited for ochameau's fix in bug 930104.