Closed
Bug 896580
Opened 11 years ago
Closed 11 years ago
[B2G] [Leo] [Email] Done button is disabled on a gallery photo page while attempting to attach it to an email
Categories
(Firefox OS Graveyard :: Gaia::Gallery, defect)
Tracking
(blocking-b2g:leo+, b2g18 verified, b2g-v1.1hd fixed)
VERIFIED
FIXED
blocking-b2g | leo+ |
People
(Reporter: ckreinbring, Assigned: dkuo)
References
Details
(Keywords: regression, smoketest)
Attachments
(3 files)
Description: Pictures in the gallery cannot be attached to emails due to the Done button being disabled. Repro Steps: 1) Update Leo to Build ID: 20130722070207 2) Launch the Email app and loging with a valid account. 3) Once the inbox loads, tap the Compose button in the upper-right. 4) Tap the paperclip icon and select Gallery. 5) Select a picture then attempt to tap the Done button in the upper right corner. Actual: The Done button is disabled, preventing the user from attaching the photo. Expected: When the user taps the Done button they are returned to the Compose page with the photo added in the attachment list. Environmental Variables Build ID: 20130722070207 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/68fb0a2e0114 Gaia: 41d10fb10be6916e6554eb440d9a97130ef23ce0 Platform Version: 18.1 RIL Version: 01.01.00.019.164 Notes: Repro frequency: 100% Q Analysts Team Priority: Pri 2 See attached screenshot and logcat logs
Reporter | ||
Comment 1•11 years ago
|
||
Comment 2•11 years ago
|
||
User is unable to use the gallery to add attachments to emails. Recommend Pri 2
blocking-b2g: --- → leo?
Comment 3•11 years ago
|
||
Attaching from the e-mail app is exposed by the Gallery app via web-activity and the button is in the domain of the Gallery app. Moving components.
Component: Gaia::E-Mail → Gaia::Gallery
Comment 4•11 years ago
|
||
Can we get a regression window here?
Keywords: regression,
regressionwindow-wanted
Comment 5•11 years ago
|
||
This seems similar to Bug 895994.
Updated•11 years ago
|
QA Contact: nkot
Comment 6•11 years ago
|
||
regression range: Build ID: 20130714230202 - Reproduces Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/f21152a848da Gaia: d52ce2278dbc2b2916a7054a220b24fb41aefd6e Platform Version: 18.1 Build ID: 20130715070218 - Does NOT reproduce Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/6062fdf2deb8 Gaia: 55ed5e08a2250ea2d3571fff860c39e66fabed14 Platform Version: 18.1 *Unagi
Keywords: regressionwindow-wanted
Comment 7•11 years ago
|
||
please disregard comment 6, regression range is incorrect! continue working on it
Updated•11 years ago
|
Keywords: regressionwindow-wanted
Comment 8•11 years ago
|
||
Correct regression range: Build ID: 20130715070218 - Does NOT reproduce Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/6062fdf2deb8 Gaia: 55ed5e08a2250ea2d3571fff860c39e66fabed14 Platform Version: 18.1 Build ID: 20130715211325 - Reproduces Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/a0fce6b5bdb2 Gaia: c8f432c60534292505fea0e0ed1897a4efe7cbec Platform Version: 18.1 *Unagi
Keywords: regressionwindow-wanted
Comment 9•11 years ago
|
||
Strange. This appears to reproduce in the email attachment use case, but works fine in the pick activity use case generally with input file (http://mozilla.github.io/qa-testcase-data/webapi/filemanagement/fileUploadTest.html). The candidate bug that caused this regression was bug 889739.
Blocks: 889739
Comment 10•11 years ago
|
||
Dominic - Can you take this? QA looking to get this fixed soon in order to get our smoketests passing again. I think the patch on bug 889739 likely caused this, so you might have a good idea how to fix this.
Flags: needinfo?(dkuo)
Comment 11•11 years ago
|
||
Dominic, can you check if this is a result of 889739?
Assignee | ||
Comment 13•11 years ago
|
||
Dale, This regression is caused by the patch of bug 889739 as Jason mentioned in comment 10, and sorry I didn't notice it breaks the pick function in email app. The root cause is the done-button will be enabled after the gallery checks the "nocrop" option, but once the nocrop is set to true, then it will just return earlier so the doen-button will not be enabled again. Would you please review this? thanks.
Attachment #779631 -
Flags: review?(dale)
Comment 14•11 years ago
|
||
Comment on attachment 779631 [details]
Enable the done button before nocrop is checked
Apologies, should have caught in review, thanks
Attachment #779631 -
Flags: review?(dale) → review+
Comment 15•11 years ago
|
||
MErged in: https://github.com/mozilla-b2g/gaia/commit/b1aea25ecaf691c3d55c4b1dca2db4c3f2ee6a7c
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 17•11 years ago
|
||
Uplifted commit b1aea25ecaf691c3d55c4b1dca2db4c3f2ee6a7c to v1-train: ef03c2b4eeba3bfca18434ccb3ea193961bf7a2b
status-b2g18:
--- → fixed
Reporter | ||
Comment 18•11 years ago
|
||
Fix verified on Leo 1.1 commercial RIL. The Done button is now functional, allowing the user to add pictures from their galley to emails. Build ID: 20130724070208 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/91fa9bf5e638 Gaia: a64f37c3327e4cf2105a16eedaf68727bb2adbde Platform Version: 18.1 RIL Version: 01.01.00.019.171
Status: RESOLVED → VERIFIED
Reporter | ||
Updated•11 years ago
|
Comment 19•11 years ago
|
||
v1.1.0hd: ef03c2b4eeba3bfca18434ccb3ea193961bf7a2b
status-b2g-v1.1hd:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•