896580 - [B2G] [Leo] [Email] Done button is disabled on a gallery photo page while attempting to attach it to an email

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Chris Kreinbring [:CKreinbring]]

Attachment: Logs of gallery attachment attempt

Description:
Pictures in the gallery cannot be attached to emails due to the Done button being disabled.

Repro Steps:
1) Update Leo to Build ID: 20130722070207
2) Launch the Email app and loging with a valid account.
3) Once the inbox loads, tap the Compose button in the upper-right.
4) Tap the paperclip icon and select Gallery.
5) Select a picture then attempt to tap the Done button in the upper right corner.

Actual:
The Done button is disabled, preventing the user from attaching the photo.

Expected:
When the user taps the Done button they are returned to the Compose page with the photo added in the attachment list.

Environmental Variables
Build ID: 20130722070207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/68fb0a2e0114
Gaia: 41d10fb10be6916e6554eb440d9a97130ef23ce0
Platform Version: 18.1
RIL Version: 01.01.00.019.164 

Notes:
Repro frequency: 100%
Q Analysts Team Priority: Pri 2
See attached screenshot and logcat logs

Comment 1

[Chris Kreinbring [:CKreinbring]]

Attachment: Screenshot of disabled Done button

Comment 2

[Allen Maxwell]

User is unable to use the gallery to add attachments to emails.

Recommend Pri 2

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Attaching from the e-mail app is exposed by the Gallery app via web-activity and the button is in the domain of the Gallery app.  Moving components.

Comment 4

[Jason Smith [:jsmith]]

Can we get a regression window here?

Comment 5

[Marcia Knous [:marcia]]

This seems similar to Bug 895994.

Comment 6

[Natalya Kot [:nkot]]

regression range:

Build ID: 20130714230202 - Reproduces
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/f21152a848da
Gaia: d52ce2278dbc2b2916a7054a220b24fb41aefd6e
Platform Version: 18.1

Build ID: 20130715070218 - Does NOT reproduce
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/6062fdf2deb8
Gaia: 55ed5e08a2250ea2d3571fff860c39e66fabed14
Platform Version: 18.1

*Unagi

Comment 7

[Natalya Kot [:nkot]]

please disregard comment 6, regression range is incorrect! 
continue working on it

Comment 8

[Natalya Kot [:nkot]]

Correct regression range:

Build ID: 20130715070218 - Does NOT reproduce
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/6062fdf2deb8
Gaia: 55ed5e08a2250ea2d3571fff860c39e66fabed14
Platform Version: 18.1

Build ID: 20130715211325 - Reproduces 
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/a0fce6b5bdb2
Gaia: c8f432c60534292505fea0e0ed1897a4efe7cbec
Platform Version: 18.1

*Unagi

Comment 9

[Jason Smith [:jsmith]]

Strange. This appears to reproduce in the email attachment use case, but works fine in the pick activity use case generally with input file (http://mozilla.github.io/qa-testcase-data/webapi/filemanagement/fileUploadTest.html).

The candidate bug that caused this regression was bug 889739.

Comment 10

[Jason Smith [:jsmith]]

Dominic - Can you take this?

QA looking to get this fixed soon in order to get our smoketests passing again. I think the patch on bug 889739 likely caused this, so you might have a good idea how to fix this.

Comment 11

[Wayne Chang [:wchang]]

Dominic, can you check if this is a result of 889739?

Comment 12

[Dominic Kuo [:dkuo]]

Taking a look.

Comment 13

[Dominic Kuo [:dkuo]]

Attachment: Enable the done button before nocrop is checked

Dale,

This regression is caused by the patch of bug 889739 as Jason mentioned in comment 10, and sorry I didn't notice it breaks the pick function in email app. The root cause is the done-button will be enabled after the gallery checks the "nocrop" option, but once the nocrop is set to true, then it will just return earlier so the doen-button will not be enabled again. Would you please review this? thanks.

Comment 14

[Dale Harvey (:daleharvey)]

Comment on attachment 779631 [details]
Enable the done button before nocrop is checked

Apologies, should have caught in review, thanks

Comment 15

[Dale Harvey (:daleharvey)]

MErged in: https://github.com/mozilla-b2g/gaia/commit/b1aea25ecaf691c3d55c4b1dca2db4c3f2ee6a7c

Comment 16

[Wayne Chang [:wchang]]

Leo+ing as a regression.

Comment 17

[Dominic Kuo [:dkuo]]

Uplifted commit b1aea25ecaf691c3d55c4b1dca2db4c3f2ee6a7c to
v1-train: ef03c2b4eeba3bfca18434ccb3ea193961bf7a2b

Comment 18

[Chris Kreinbring [:CKreinbring]]

Fix verified on Leo 1.1 commercial RIL.  The Done button is now functional, allowing the user to add pictures from their galley to emails.

Build ID: 20130724070208
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/91fa9bf5e638
Gaia: a64f37c3327e4cf2105a16eedaf68727bb2adbde
Platform Version: 18.1
RIL Version: 01.01.00.019.171

Comment 19

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: ef03c2b4eeba3bfca18434ccb3ea193961bf7a2b