896597 - nsXULPDGlobalObject_finalize does non-deferred release

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

We've had problems when not using deferred release during finalize, so I think we should
use it in nsXULPDGlobalObject_finalize too.

(Bug 712448 was a rather major problem.)

Comment 1

[Andrew McCreight [:mccr8]]

Feel free to change sec-other to something else if you think there's a real problem here.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Be consistent with other stuff.

It is not clear to me whether non-deferred release can actually lead to problems
in this case. This release tends to happen when we're shutting down.

Comment 3

[Andrew McCreight [:mccr8]]

Comment on attachment 779406 [details] [diff] [review]
patch

Review of attachment 779406 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d06db659283d

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d06db659283d