Closed Bug 896597 Opened 7 years ago Closed 7 years ago

nsXULPDGlobalObject_finalize does non-deferred release

Categories

(Core :: XUL, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25
Tracking Status
firefox25 --- fixed
firefox-esr17 --- wontfix
firefox-esr24 --- wontfix
b2g18 --- wontfix

People

(Reporter: smaug, Assigned: smaug)

Details

(Keywords: sec-other, Whiteboard: [adv-main25-])

Attachments

(1 file)

We've had problems when not using deferred release during finalize, so I think we should
use it in nsXULPDGlobalObject_finalize too.

(Bug 712448 was a rather major problem.)
Assignee: nobody → bugs
Keywords: sec-other
Feel free to change sec-other to something else if you think there's a real problem here.
Attached patch patchSplinter Review
Be consistent with other stuff.

It is not clear to me whether non-deferred release can actually lead to problems
in this case. This release tends to happen when we're shutting down.
Attachment #779406 - Flags: review?(continuation)
Comment on attachment 779406 [details] [diff] [review]
patch

Review of attachment 779406 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable.
Attachment #779406 - Flags: review?(continuation) → review+
https://hg.mozilla.org/mozilla-central/rev/d06db659283d
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Whiteboard: [adv-main25-]
Group: core-security
You need to log in before you can comment on or make changes to this bug.