Closed Bug 896651 Opened 6 years ago Closed 6 years ago

Need to clean up resources for out-of-process layer trees when shutting down

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla25

People

(Reporter: billm, Assigned: billm)

Details

Attachments

(1 file)

gfx-shutdown-fix
2.87 KB, patch
mattwoodrow
: review+
Details | Diff | Splinter Review
Attached patch gfx-shutdown-fix — — Splinter Review 
When I run with browser.tabs.remote=true, I usually get an X crash on shutdown. There's a texture that's getting destroyed after the X window has been destroyed. When we destroy the texture, we try to switch to its GL context, but that fails because the window backing it is gone.

This patch clears up the resources for detached layer trees when shutting down.
Attachment #779357 - Flags: review?(matt.woodrow)
Attachment #779357 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/34c79a7de41f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.