896664 - Fix Safari design QA bugs for /event-guides

Status: RESOLVED INCOMPLETE

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Cassie McDaniel [:cassiemc]]

* the bottom blue buttons are using the wrong > chevron. Should match the size and styles of other font-awesome icons throughout the site. https://docs.google.com/file/d/0BzfN9sXlOXt1aWFud1NzdmlpSlk/edit?usp=sharing
* on the responsive, mobile resolution, there is no vertical space between each panel. They are sitting right on top of each other. Add 10-20 px space between them. https://docs.google.com/file/d/0BzfN9sXlOXt1UnNfNWwzZy14ajQ/edit?usp=sharing

Comment 1

[shaj]

Can I be assigned to this bug if it is still available?

Comment 2

[Pomax]

all yours!

Comment 3

[Pomax]

Example of the "regular" fontawesome chevron/style: https://webmaker.org/en-US/tools

Comment 4

[shaj]

Attachment: Bug fix for 896664

All information about the changes made can be found at my blog: http://shaj02.wordpress.com/ and repository at https://github.com/shaj02/webmaker.org - I tried to complete the entire list of bugs that was in the comments section. Please review my work, thanks.

File URL: https://github.com/shaj02/webmaker.org/archive/master.zip

Comment 5

[Pomax]

nice! However, in order to track work on bugs inside the bugs themselves, we try to keep the information available inside the bugs. If you have a code patch, from your repository file a pull request to the mozilla repository, and then attach the pull request URL as an attachment: click "add attachment" and then fill in the URL as the file text, as well as the description, and then set someone to review it. This'll create an attachment comment with a clickable link to the pull request.

Also, any rationales and inventory work that is relevant to the bug should go in the bug itself, even if you blog about it. Blogging is great, so don't unpublish what you're written, but also add the important information to the bug so that people can do their review and comments based only on what's in the bug, without having to reach out to other websites to find out what work is being done.

Comment 6

[shaj]

Attachment: https://github.com/mozilla/webmaker.org/pull/518

Fixed incorrect chevron ( > [arrow], issues with the mobile responsive layout of this website. I modified the CSS tags in the file ui.less, where the focus was mainly on the media tags. Specifically, I added 10 to 20 pixels of space between each panel. I also increased the bottom spacing to make the content less cluttered for a mobile user. Also fixed spacing and alignment problems from [bug 935001] in style.less

Comment 7

[Pomax]

Comment on attachment 8339304 [details] [review]
https://github.com/mozilla/webmaker.org/pull/518

this is a combined patch for #8339307 and #896664: please split it up into two patches, one for this ticket, and one for the other. Each bug gets addressed in its own patch.

Comment 8

[shaj]

Pull request sent with Bug #896664 split. 
https://github.com/mozilla/webmaker.org/pull/534

Comment 9

[shaj]

Attachment: https://github.com/mozilla/webmaker.org/pull/534

https://github.com/mozilla/webmaker.org/pull/534

Comment 10

[shaj]

Please review attachment to Pull request. Thank you.

Comment 11

[Pomax]

Comment on attachment 8341416 [details] [review]
https://github.com/mozilla/webmaker.org/pull/534

you probably meant for this to be a review request, not a needinfo

Comment 12

[Pomax]

Comment on attachment 8341416 [details] [review]
https://github.com/mozilla/webmaker.org/pull/534

while technically allowed in HTML, maintainable code cannot contain any style="..." markup. All the styling has to go in stylesheets so they can be modified without having to hunt for collisions between stylesheet-indicated rules, and inline style="..." overrides

Comment 13

[Ali Al Dallal [:alicoding]]

Closing this as incomplete for now and feel free to reopen?