Closed Bug 896687 Opened 11 years ago Closed 11 years ago

Remove PanelUI-mainView-spring

Categories

(Firefox :: Toolbars and Customization, defect)

x86_64
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: mconley, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:M9][Australis:P5])

Attachments

(1 file)

PanelUI-mainView-spring is an element in the menu panel main view whose sole purpose is to consume space when viewing a subview that is taller then the main view. That way, the footer gets pushed to the bottom.

We should probably be able to make this work without the spring by making the PanelUI-contents (or parent) flex. We should investigate that, since it would let us simplify the mark-up some.
This seems to work just fine.
Attachment #811970 - Flags: review?(mdeboer)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 811970 [details] [diff] [review]
remove PanelUI-mainView-spring,

I suppose either Mike could review this! ;-)
Attachment #811970 - Flags: review?(mconley)
Comment on attachment 811970 [details] [diff] [review]
remove PanelUI-mainView-spring,

Review of attachment 811970 [details] [diff] [review]:
-----------------------------------------------------------------

I'm no Mike, but...
Attachment #811970 - Flags: review?(mdeboer)
Attachment #811970 - Flags: review?(mconley)
Attachment #811970 - Flags: review+
https://hg.mozilla.org/projects/ux/rev/d7cfe43bfada
Whiteboard: [Australis:M?][Australis:P5] → [Australis:M9][Australis:P5][fixed-in-ux]
Summary: See if PanelUI-mainView-spring is really necessary → Remove PanelUI-mainView-spring
https://hg.mozilla.org/mozilla-central/rev/d7cfe43bfada
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M9][Australis:P5][fixed-in-ux] → [Australis:M9][Australis:P5]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: