bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Remove PanelUI-mainView-spring

RESOLVED FIXED in Firefox 28

Status

()

Firefox
Toolbars and Customization
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mconley, Assigned: Gijs)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 28
x86_64
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Australis:M9][Australis:P5])

Attachments

(1 attachment)

PanelUI-mainView-spring is an element in the menu panel main view whose sole purpose is to consume space when viewing a subview that is taller then the main view. That way, the footer gets pushed to the bottom.

We should probably be able to make this work without the spring by making the PanelUI-contents (or parent) flex. We should investigate that, since it would let us simplify the mark-up some.
(Assignee)

Comment 1

5 years ago
Created attachment 811970 [details] [diff] [review]
remove PanelUI-mainView-spring,

This seems to work just fine.
Attachment #811970 - Flags: review?(mdeboer)
(Assignee)

Updated

5 years ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Comment on attachment 811970 [details] [diff] [review]
remove PanelUI-mainView-spring,

I suppose either Mike could review this! ;-)
Attachment #811970 - Flags: review?(mconley)
Comment on attachment 811970 [details] [diff] [review]
remove PanelUI-mainView-spring,

Review of attachment 811970 [details] [diff] [review]:
-----------------------------------------------------------------

I'm no Mike, but...
Attachment #811970 - Flags: review?(mdeboer)
Attachment #811970 - Flags: review?(mconley)
Attachment #811970 - Flags: review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/projects/ux/rev/d7cfe43bfada
Whiteboard: [Australis:M?][Australis:P5] → [Australis:M9][Australis:P5][fixed-in-ux]

Updated

5 years ago
Summary: See if PanelUI-mainView-spring is really necessary → Remove PanelUI-mainView-spring
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/d7cfe43bfada
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M9][Australis:P5][fixed-in-ux] → [Australis:M9][Australis:P5]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.