Closed Bug 896717 Opened 12 years ago Closed 12 years ago

Width of Google Pie Graph is not sufficient to show branch names

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: zeller, Assigned: zeller)

Details

Attachments

(2 files, 2 obsolete files)

bug896717.patch
605 bytes, patch
nthomas
: review+
nthomas
: checked-in+
Details | Diff | Splinter Review
bug896717-2.patch
2.67 KB, patch
nthomas
: review+
nthomas
: checked-in+
Details | Diff | Splinter Review
The width of the Google Pie Graph at the bottom of the BuildAPI pushes report is too narrow and cuts off the names of the branches, forcing you to highlight it to see the tooltip of the whole name. This is the page that the big shows up on https://secure.pub.build.mozilla.org/buildapi/reports/pushes
Attached patch bug896717.patch — — Splinter Review
This patch should fix the issue. Almost as stupid simple as it gets.
Attachment #779421 - Flags: review?(nthomas)
Comment on attachment 779421 [details] [diff] [review] bug896717.patch woot!
Attachment #779421 - Flags: review?(nthomas) → review+
Assignee: nobody → jozeller
Attached patch bug896717-2.patch (obsolete) — — Splinter Review
This patch should take care of the same issue but for the line and bar graphs above the pie chart.
Attachment #779474 - Flags: review?(nthomas)
Okay this should fix the issue with using '' on lines 37 and 39 in pushes.mako
Attachment #779474 - Attachment is obsolete: true
Attachment #779474 - Flags: review?(nthomas)
Attachment #779530 - Flags: review?(nthomas)
Attached patch bug896717-2.patch (obsolete) — — Splinter Review
Changed font size of legend from 8 to 11
Attachment #779530 - Attachment is obsolete: true
Attachment #779553 - Flags: review?(nthomas)
Comment on attachment 779553 [details] [diff] [review] bug896717-2.patch I'd already landed the patch for 8pt, and this is the followup to change it to 11 https://hg.mozilla.org/build/buildapi/rev/aaf87a93ade9
Attachment #779553 - Attachment is obsolete: true
Attachment #779553 - Flags: review?(nthomas)
Attachment #779530 - Attachment is obsolete: false
Everything looks good here!
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: Tools → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: