896729 - Attempt to re-register network link service crashes nsComponentManager

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Tatiana Meshkova (:tatiana)]

Attachment: backtrace

Qt Firefox crashes at startup, see backtrace.

Comment 1

[Tatiana Meshkova (:tatiana)]

It's Ubuntu desktop.

Comment 2

[Scoobidiver (away)]

Duplicate of bug 881237?

Comment 3

[Tatiana Meshkova (:tatiana)]

(In reply to Scoobidiver from comment #2)
> Duplicate of bug 881237?

Not exactly. It crashes because LogMessage is called from the lock as explained by Benjamin in bug 881237 comment 5, but I doubt the guilty CID is the same.

Comment 4

[Tatiana Meshkova (:tatiana)]

Here it is 75a500a2-0030-40f7-86f8-63f225b940ae.
First time it was hardcoded here http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/netwerk/build/nsNetCID.h&rev=1.72&mark=816#816
Then here http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/system/dbus/nsDBusModule.cpp&rev=1.1&mark=50#50

@roc: NS_DBUS_NETWORK_LINK_SERVICE_CID is identical with NS_NETWORK_LINK_SERVICE_CID. Are they meant to be the same?

Comment 5

[Benjamin Smedberg]

Typically different implementations of a service should have the same contractID and different CIDs. It seems that necko uses the same CID for all of its network link service implementations, and it happens that in the QT build we are registering both:

nsQtNetworkLinkServiceConstructor and the DBUS nsNetworkManagerListenerConstructor.

Are we really supposed to be building both of these? Which one is the "actual" network link service?

We should also randomize the CIDs, I think.

Comment 6

[Tatiana Meshkova (:tatiana)]

Attachment: patch

DBus network link service is no longer in use since Bug 586836. No reason to build it.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7cd08e2beee1

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7cd08e2beee1