Closed
Bug 896749
Opened 11 years ago
Closed 11 years ago
Padding between URL Bar and Bookmarks Toolbar with Australis
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: zilvinas.urbon, Assigned: Gijs)
References
Details
(Whiteboard: [Australis:P4][Australis:M9])
Attachments
(3 files)
Screenshot.png
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/30.0.1568.2 Safari/537.36 Steps to reproduce: Enabled Bookmarks toolbar. Actual results: It appeared with bad padding between url bar and bookmarks toolbar. Expected results: Should have seen proper padding between URL Bar and Bookmarks Toolbar. I believe the problem wouldn't exist if one would still have ability to "Use Small Icons" for Toolbar. I believe all of that side effects is caused by Back button.
|
||
Comment 1•11 years ago
|
||
Stephen, this isn't covered in the spec. How much space should there be between the two toolbars?
Blocks: australis
Component: Untriaged → Theme
Flags: needinfo?(shorlander)
Summary: Padding between URL Bar and Bookmarks Toolbar → Padding between URL Bar and Bookmarks Toolbar with Australis
Whiteboard: [Australis:P4]
Version: 25 Branch → unspecified
|
||
Updated•11 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
Assignee | |
Comment 3•11 years ago
|
||
This patch depends on bug 930045's patch. Stephen and I agreed over IRC to use a 4px total padding on each side, to ensure the bookmarks' toolbar looks centered. This patch does that.
Attachment #821798 -
Flags: review?(mdeboer)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
|
||
Comment 4•11 years ago
|
||
Comment on attachment 821798 [details] [diff] [review] fix bookmarks' vertical centering, Review of attachment 821798 [details] [diff] [review]: ----------------------------------------------------------------- LGTM! Beware that this patch has bitrot.
Attachment #821798 -
Flags: review?(mdeboer) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
https://hg.mozilla.org/projects/ux/rev/0cb33b13e2ca
Whiteboard: [Australis:P4] → [Australis:P4][Australis:M9][fixed-in-ux]
|
|
Assignee | |
Comment 37•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0cb33b13e2ca
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P4][Australis:M9][fixed-in-ux] → [Australis:P4][Australis:M9]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•