89679 - Pause/resume handling of http errors is hacky

Status: RESOLVED WORKSFORME

(SeaMonkey :: Installer, defect)

Description

[Syd Logan]

The http code in libxpnet handles critical http failures by putting the ui into 
pause mode, and does not communicate to the user what is going on. It 
really should take a look at the response codes more critically, some of them 
should be displayed to the user, in some cases the user should be allowed to 
quit the installer as a result, and for the ones that we are putting the user 
into pause state for, why the hell not just retry ourselves a couple of times 
and then hard fail if it persists? I see no point in making the user click a 
button until we have, on our own, tried the operation a couple of times. If we 
are getting response codes back, then we have a connection, and it's not like we 
need the user to plug in the network and hit resume or something. 

Error handling in http is bad enough that we should consider not exposing this 
feature until it gets fixed.

Comment 1

[Syd Logan]

nominating

Comment 2

[Blake Ross]

Missed 0.9.3.

Comment 3

[Syd Logan]

moving out to mozilla 1.0

Comment 4

[Grace Bush]

nsbeta1+ issues for Win Installer

Comment 5

[Jaime Rodriguez, Jr.]

nsbeta1- per ADT/XPInstall triage.

Comment 6

[selmer (gone)]

Please update this bug with an [adt1] - [adt3] impact rating (or take it off the
list if it doesn't even rate adt3.)  Thanks!

Comment 7

[timeless]

macos9.0.4, custom spin.
I grabbed my build from komodo, and ran it.
because ftp is no longer an alias for komodo, the files had not replicated to 
ftp.mozilla.org.

so i tried to install, it didn't tell me what file it was trying to installer, 
after a while it just switched to pause mode.
(cancel) was disabled. it took me a while to figure out that I could do 
file>quit.

I should have been told:
1. what file the app was trying to get
2. when it failed, why it failed

And, I should have been able to click (cancel)

C. It might also be nice (well, maybe not), to let me select an alternate 
server/path. [I'll file an RFE unless someone indicates it's already filed]

Comment 8

[Andrew Schultz]

is this still a problem on Windows?
On linux, the error message isn't particularly descriptive (or even correct),
but it does show one and retries several times before giving up.

Comment 9

[Matthias Versen [:Matti]]

Seamonkey and Firefox are using a new NSIS based installer. resolving this old bug, please reopen if you still get this with the new installer