Follow up (894865) - Implement/Polish list of duplicate contacts to merge with correct design

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: crdlc, Assigned: salva)

Tracking

unspecified
All
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:koi+)

Details

(Whiteboard: [u=commsapps-user c=contacts p=3])

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
The current implementation is the next one after landing bug 894865

http://i.imgur.com/jzMb6NL.png

following the wireframe
(Reporter)

Updated

6 years ago
Depends on: 894865
(Reporter)

Updated

6 years ago
blocking-b2g: --- → koi?
Whiteboard: [u=commsapps-user c=contacts p=3]
Blocks: 895797
blocking-b2g: koi? → koi+
Assignee: nobody → salva
Ayman, can you confirm this screenshot shows all what I need to implement the merging contacts list properly?
Flags: needinfo?(aymanmaat)

Comment 2

6 years ago
(In reply to Salvador de la Puente González [:salva] from comment #1)
> Ayman, can you confirm this screenshot shows all what I need to implement
> the merging contacts list properly?

Hey Salva

required functionality is as detailed in page 19 of FFOS_MergeContacts_V1.2_20130807_V5.0

ping me if you need to discuss
Flags: needinfo?(aymanmaat)
Created attachment 798944 [details]
Visuals for suggest duplicate contacts

The done button at the right-top corner must disappear.

Ayman suggest to avoid the highlight (Darker background) for unchecked contacts but this is a building block.

Asking for feedback.
Attachment #798944 - Flags: feedback?(vpg)
Attachment #798944 - Flags: feedback?(aymanmaat)
Created attachment 798946 [details]
Current state of the patch

Current state of the patch concerning visuals. Note how contacts can be seen behind the button area.

The button color has changed to highlight merging contact is a definitive action.
Attachment #798946 - Flags: feedback?(vpg)
Attachment #798946 - Flags: feedback?(aymanmaat)
Created attachment 800324 [details]
Visual polish and behavior completed

Here there are three kinds of changes:

- Changes in the UI, markup, style and behaviour.
- Changes in matcher to provide the second paragraph of each contact in the screen.
- Test related changes to both cover the main reason selection and updates to the mocked markup.

If you prefer three different commits, let me know and we can land this progressively.
Attachment #800324 - Flags: review?(jmcf)
Comment on attachment 800324 [details]
Visual polish and behavior completed

please revert the two incorrect changes marked in GH and then merge. 

thanks for the work
Attachment #800324 - Flags: review?(jmcf) → review+
Master: 45b79e60d1b15d53ff60348d812d732affb19cb6
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 8

5 years ago
Comment on attachment 798946 [details]
Current state of the patch

removing feedback request to me as bug now marked as fixed.
design was discussed and feedback given, but but never updated with outcome.
Attachment #798946 - Flags: feedback?(aymanmaat) → feedback-

Comment 9

5 years ago
Comment on attachment 798944 [details]
Visuals for suggest duplicate contacts

removing feedback request to me as bug now marked as fixed.
design was discussed and feedback given, but but never updated with outcome.
Attachment #798944 - Flags: feedback?(aymanmaat) → feedback-
Attachment #798944 - Flags: feedback?(vpg) → feedback-
Attachment #798946 - Flags: feedback?(vpg) → feedback-
You need to log in before you can comment on or make changes to this bug.