Closed
Bug 896934
Opened 12 years ago
Closed 12 years ago
[Settings] Listen new system message for Bluetooth pairing requests in connectivity.js
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: arthurcc, Assigned: gduan)
Details
Attachments
(1 file, 1 obsolete file)
Should also listen to the new message in connectivity.js to reflect the change of Bug 853235.
| Assignee | ||
Updated•12 years ago
|
Assignee: arthur.chen → gduan
| Assignee | ||
Comment 1•12 years ago
|
||
This patch replace requestconfirmation/requestpincode/requestpasskey with bluetooth.paring.request and also use eventlistener in bluetooth.js .
Attachment #787377 -
Flags: review?(arthur.chen)
| Reporter | ||
Comment 2•12 years ago
|
||
Comment on attachment 787377 [details]
PR to master
Thank you for the effort! r=me with the only one comment addressed.
Attachment #787377 -
Flags: review?(arthur.chen) → review+
| Assignee | ||
Comment 3•12 years ago
|
||
Thanks Arthur, I added the comment back.
Merge into master
https://github.com/mozilla-b2g/gaia/commit/be32a0963b32f79a72d03c5059f09f067c19aebc
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
| Assignee | ||
Comment 4•12 years ago
|
||
Regression and cause bug 907441 .
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
| Assignee | ||
Comment 5•12 years ago
|
||
Hi Arthur,
Previous PR has some regression due to registering event too many times, so I reopen this bug and revert previous commit 125d2e74097c200649375abd446251adf3f2bab9.
And this patch should fix the problem.
Could you kindly check again? Thanks.
Attachment #794423 -
Flags: review?(achen)
| Reporter | ||
Comment 7•12 years ago
|
||
Comment on attachment 794423 [details]
PR to master
Thanks for the quick patch! r=me.
Attachment #794423 -
Flags: review?(achen) → review+
| Assignee | ||
Updated•12 years ago
|
Attachment #787377 -
Attachment is obsolete: true
Attachment #787377 -
Flags: review+
| Assignee | ||
Comment 8•12 years ago
|
||
Thanks,
Merge into master.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
| Assignee | ||
Comment 9•12 years ago
|
||
Thanks,
Merge into master.
https://github.com/mozilla-b2g/gaia/commit/14f47e5390f6fb9b0c4c841f34024870b7052cfb
You need to log in
before you can comment on or make changes to this bug.
Description
•