[Music][HD] Music app need 1.5x ratio pictures for hd versions

VERIFIED FIXED

Status

VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: atsai, Assigned: dkuo)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:hd+, b2g-v1.1hd fixed)

Details

(Whiteboard: helix vsd)

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
We need 1.5x ratio pictures. At least, we need the same files with 1.5x ratio naming.

+music.gaiamobile.org/application/style/images/progress.png
+music.gaiamobile.org/application/style/images/tabs_albums.png
+music.gaiamobile.org/application/style/images/tabs_artists.png
+music.gaiamobile.org/application/style/images/tabs_mix.png
+music.gaiamobile.org/application/style/images/tabs_playlists.png
(Reporter)

Updated

5 years ago
Blocks: 896939
(Reporter)

Updated

5 years ago
Blocks: 896942
(Reporter)

Updated

5 years ago
Blocks: 896944
(Reporter)

Updated

5 years ago
No longer blocks: 896944
(Reporter)

Updated

5 years ago
No longer blocks: 896942
(Reporter)

Updated

5 years ago
No longer blocks: 896939
(Reporter)

Updated

5 years ago
No longer depends on: 896932, 896936, 896937
blocking-b2g: --- → hd?
Flags: needinfo?(dkuo)
(Assignee)

Comment 1

5 years ago
(In reply to Al Tsai [:atsai] from comment #0)
> We need 1.5x ratio pictures. At least, we need the same files with 1.5x
> ratio naming.
> 
> +music.gaiamobile.org/application/style/images/progress.png

Thanks, I missed this one, and I can copy it from gallery or video.

> +music.gaiamobile.org/application/style/images/tabs_albums.png
> +music.gaiamobile.org/application/style/images/tabs_artists.png
> +music.gaiamobile.org/application/style/images/tabs_mix.png
> +music.gaiamobile.org/application/style/images/tabs_playlists.png

Actually these four images are no longer used in music app, they are already removed in master but v1.1.0hd, and I think we can just remove them.
Flags: needinfo?(dkuo)
(Assignee)

Updated

5 years ago
Assignee: nobody → dkuo
HD+ asset bug
blocking-b2g: hd? → hd+
(Assignee)

Updated

5 years ago
Depends on: 894203
Assignee: dkuo → amylee.design
Whiteboard: helix vsd
(Assignee)

Comment 3

5 years ago
Created attachment 786160 [details]
Add the lacked 1.5x images for music app on hd branch

Rex,

This patch removes the unused images and adds the lacked 1.5x images for music app. For updating all the images to the latest version on master/hd branches, I will use bug 894203 to do it, so can you please review this patch first? thanks.
Attachment #786160 - Flags: review?(rexboy)
Comment on attachment 786160 [details]
Add the lacked 1.5x images for music app on hd branch

Looks good to me.

Well I fired a search around apps/music but didn't find progress.png included in
any files. Was it moved to building block? It doesn't affect landing this bug
though, just a confirmation.
Attachment #786160 - Flags: review?(rexboy) → review+
(Assignee)

Comment 5

5 years ago
Do you mean this one?

https://github.com/mozilla-b2g/gaia/blob/v1.1.0hd/apps/music/style/images/progress.png
Assignee: amylee.design → dkuo
(Assignee)

Comment 6

5 years ago
Okay, I found that progress.png is no more used in music app so I just remove it from the assets.
(Assignee)

Comment 7

5 years ago
Landed on v1.1.0hd: daeff203d637cae4244139ca4bf5a01df0845119
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-b2g-v1.1hd: --- → fixed
Resolution: --- → FIXED
(Reporter)

Updated

5 years ago
QA Contact: atsai
(Reporter)

Updated

5 years ago
Status: RESOLVED → VERIFIED

Comment 8

5 years ago
Thanks for all your help!
The redundant images has been removed.

* Test build:(Mozilla-b2g18_v1_1_0_hd-helix/2013-08-15-04-22-01)
  + Mercurial-Information
    - Gecko revision="bd0864949c0f"
  + Git-information
    - Gaia revision="d04d2d3969e4366fabafe9659f9b2705b7879ac2"

Marked as "Verified"+"Fixed"
Attaching the screenshot.

Comment 9

5 years ago
Created attachment 791227 [details]
Music app
You need to log in before you can comment on or make changes to this bug.