896954 - AudioManager `s setFmVolume issues.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: General, defect, P2)

Description

[leo.bugzilla.gecko]

static void
InternalSetAudioRoutesICS(SwitchState aState)
{
  ...
  // The audio volume is not consistent when we plug and unplug the headset.
  // Set the fm volume again here.
  if (IsDeviceOn(AUDIO_DEVICE_OUT_FM)) {
    float masterVolume;
    AudioSystem::getMasterVolume(&masterVolume);
    AudioSystem::setFmVolume(masterVolume);
  }
}
============================================================================
getMasterVolume function means it returns mastervolume. It always return value 1.0

Comment 1

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: patch v1

remove those code,
The volume would be set by SetStreamVolumeIndex and SetFmRadioAudioEnabled.

Comment 2

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Only apply b2g-18 branch, master trunk has already removed those source code.

Comment 3

[Marco Chen [:mchen]]

Comment on attachment 780213 [details] [diff] [review]
patch v1

Review of attachment 780213 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the help on this bug.
And the bug for master branch is Bug 876334.

Comment 4

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: check-in patch

check-in patch, carry reviewer.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Please hold off on requesting checkin until this has blocking status since this is b2g18-only.

Comment 6

[bhavana bajaj [:bajaj]]

what exactly is the issue here, if the attached patch is not applied ? Can you please explain a bit more for us to block on this.Without user impact it is hard to block

Comment 7

[Seil Park]

(In reply to bhavana bajaj [:bajaj] from comment #6)
> what exactly is the issue here, if the attached patch is not applied ? Can
> you please explain a bit more for us to block on this.Without user impact it
> is hard to block

Fortunately, It is fine in leo device because it set volume again by SetFmRadioAudioEnabled. 
But this code always set fm volume to 1 level. It isn`t needed and must be removed for avoiding a wrong logic.

Comment 8

[Alex Keybl [:akeybl]]

No known user impact, therefore not a blocker.

Comment 9

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

free it due to no obvious impact for this one.

Comment 10

[BMO Automation]

Firefox OS is not being worked on