Add base JS unit tests for bedrock global.js

VERIFIED FIXED

Status

www.mozilla.org
Bedrock
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: agibson, Assigned: agibson)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

5 years ago
While working a bug I wrote some basic unit tests for one of the functions in bedrock's global.js. 

I thought it would be useful to expand on this and write more tests for global.js, so will use this bug for the wider piece of work.
(Assignee)

Updated

5 years ago
Assignee: nobody → agibson

Comment 1

5 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/cfaec7e75ef2a5cbeddc0969f79eacdb2c3b26ff
[fix bug 896961] Add base JS unit tests for bedrock global.js

https://github.com/mozilla/bedrock/commit/15de42eb7eedfd981a16a70cba6b46b850ae3933
Merge pull request #1107 from alexgibson/add-js-unit-tests-for-global-js

[fix bug 896961] Add base JS unit tests for bedrock global.js

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 2

5 years ago
Reopening this bug as have made a small refactor to two of the initial tests. New PR to follow.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 4

5 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/c2e4b9f3b8ce0ef87006f82cef8e9e40bd577b64
[bug 896961] Small refactor for two global.js unit tests

https://github.com/mozilla/bedrock/commit/641a808ae366795d344b6a971df652fb7f27bece
Merge pull request #1137 from alexgibson/update-globaljs-unit-tests

[bug 896961] Small refactor for two global.js unit tests
(Assignee)

Updated

5 years ago
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.