Closed Bug 897065 Opened 11 years ago Closed 5 years ago

Create/Import more MathML layout tests

Categories

(Core :: MathML, defect)

Product:
Core
Component:
MathML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: fredw, Unassigned, Mentored)

References

(Depends on 1 open bug)

Details

(Keywords: helpwanted) 

We now have several MathML reftests

http://mxr.mozilla.org/mozilla-central/source/layout/reftests/mathml/

that have been created while implementing new features and fixing bugs. However, we still don't have any reftests to test basic things like positions of tables or scripts. It would be good to write new tests for that, perhaps importing existing ones from WebKit, MathJax or the MathML Acid tests (check license compatibility). This work is large and may be split into several patches and could be shared between several contributors. This is a good opportunity to get familiar with the reftest framework and MathML language for future contributions to Gecko.

Some MathML tests that could be imported:
https://github.com/mathjax/MathJax-test/tree/master/testsuite/MathMLToDisplay
http://trac.webkit.org/browser/trunk/LayoutTests/mathml/presentation (see also those on https://bugs.webkit.org/show_bug.cgi?id=47744)
https://github.com/fred-wang/AcidTestsMathML

Helpful doc:
https://developer.mozilla.org/en-US/docs/Introduction
https://developer.mozilla.org/en-US/docs/Creating_reftest-based_unit_tests
http://www.w3.org/TR/MathML/ (especially chapters 2 and 3)
https://developer.mozilla.org/en-US/docs/Web/MathML

ankitsablok89 said on IRC he was interested to work on that bug.
Will he take that, or should I do it?
Depends on: 963453
@fredw: Can I take this bug?
@Michael, Anuj: anyone can work on this. That will really improve our test coverage and help test engineers. I suspect it would be best to split the work into smaller bugs. So the first task would be to analyze what kind of test is missing.
I think we could start by two basic elements: mfrac and mtable.
Depends on: 975681
Depends on: 989270
Mentor: fred.wang
Whiteboard: [mentor=fredw]
Hello. I have contributed on Mozilla bugs before. I would like to work on this one. 

I've never worked on "student-project" bugs before, so a little overview would be helpful.

BTW: Is the scope good enough for use as a valid proposal for GSOC 2015 [1]? In that case I would be happy to work on it through GSOC as well.

[1]: https://wiki.mozilla.org/Community:SummerOfCode15
Flags: needinfo?(fred.wang)
Hi Abhishek,

> I would like to work on this one.

Be welcome.

> I've never worked on "student-project" bugs before, so a little overview would be helpful.

"Student-project" is like "good-first-bug". You don't need to much much about Mozilla source code to help with it and someone can help you with it if you need.

> BTW: Is the scope good enough for use as a valid proposal for GSOC 2015 [1]?

I'm not sure. We will have a MathML meeting, https://wiki.mozilla.org/MathML:Home_Page#Meeting_Notes, right before the students application open. If you want to get a note about it please send me a email.
The idea of this bug is to have a better test coverage for MathML, so the work is essentially to write new tests or import/adapt existing tests from other test suites. This is a big task that can be split into smaller bugs (see bug 963453 and bug 975681 for the typical work asked). As a good start, it is important to read the "helpful doc" in comment 0, try and build Firefox as well as run the tests.

To take this as a student/GSOC project, one will have to analyze the MathML attributes/elements currently supported and what tests we currently have. Then one will need to define a set of goals for new tests to write. Currently, the "depends on" field refers to the open bug 989270 (mo tests) but more should be added.

Also, in order to have a chance to be accepted for GSOC, it is very important to have a mentor. I won't have time be a mentor this summer but as Raniere said this will be discussed during the next MathML meeting, so perhaps some people will be willing to mentor this or other proposals.
Flags: needinfo?(fred.wang)
Hello,

I am new to bugzilla and I am really not familiar with how to access Mozilla Code Base for MathML,

Can someone help me?

Thankxxx
Did did you read the "helpful doc" of comment 0? (get the source, build Firefox, execute reftests).
Thank You,

I will look on to that and figure out how to reach to that bug.
Hello, 
I am a newbie to Open Source. What shall I do to start??
Hi! I would also like to help with this. I am a current student, and have never worked on an Open Source project before. Are there any specific tasks I should begin with?
@Aditi: I believe https://github.com/w3c/web-platform-tests/tree/master/mathml is important and we should now have it imported into our test suite. It would be worth checking whether they pass on all platforms.

Hi! I am new to opensource. Can anyone tell me how to get started. I would like to contribute in this.

Sir I am UG student from India. I have contributed before for Mozilla and I would love to implement this functionality. Can we discuss it on some irc ? or can you leave me any hint ? Let me know!

I tested one tests from webkit (mo-form) and it runs fine. Shall I put on Phab and let you review. But I want a more detailed insight on what is happening here. Can I discuss on irc sometime?
Also I see these new tests are added https://github.com/web-platform-tests/wpt/tree/master/mathml
Let me know.

Hi. Thank you everybody for your interest.

This bug is very old, but the status these days are:

  • For new tests, contributing directly to the upstream WPT repo is recommended.
  • WPT tests are automatically imported into Mozilla.

So I think we can close this.

There is a MathML Refresh community group leading standardization and testing for MathML:
https://mathml-refresh.github.io/

I invite people to get in touch with that group and see how they can help. In particular, writing tests for the MathML Core spec is very important.

Status: NEW → RESOLVED
Closed: 5 years ago
Keywords: student-project
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.