[fig] Menu button visibile in editing mode in private browsing mode

RESOLVED FIXED in Firefox 26

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Margaret, Assigned: sriram)

Tracking

Trunk
Firefox 26
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: abouthome-hackathon, fixed-fig)

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 779871 [details]
screenshot

See screenshot.
(Assignee)

Comment 1

5 years ago
Created attachment 780008 [details] [diff] [review]
Patch

I don't like how the menu button is split into two. Should investigate the reason and merge them both into one. But this patch works fine with current code base.
Attachment #780008 - Flags: review?(margaret.leibovic)
(Assignee)

Updated

5 years ago
Assignee: nobody → sriram
(Reporter)

Comment 2

5 years ago
Comment on attachment 780008 [details] [diff] [review]
Patch

I'm going to redirect this review to lucasr, since he's more familiar with this code.
Attachment #780008 - Flags: review?(margaret.leibovic) → review?(lucasr.at.mozilla)
Comment on attachment 780008 [details] [diff] [review]
Patch

Review of attachment 780008 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch. Menu button split was added so that we could fade out the tab counter and menu icon but keep the dark gray background behind them when the tabs tray is open.
Attachment #780008 - Flags: review?(lucasr.at.mozilla) → review+
(Assignee)

Comment 4

5 years ago
We could have done that with an image level on the menu button right?
(In reply to Sriram Ramasubramanian [:sriram] from comment #4)
> We could have done that with an image level on the menu button right?

How would you go about fading out only the icon while keeping the button's background color using image levels?
(Assignee)

Comment 6

5 years ago
The background color is supplied by android:background property. The android:src property can show a LevelDrawable. The current menu level has transparency in it for level 2. To provide a "fade" effect, a TransistionDrawable can be used. That allows switching between two levels with an animation.
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/projects/fig/rev/ce8381f138cc
Whiteboard: abouthome-hackathon → abouthome-hackathon, fixed-fig
(In reply to Sriram Ramasubramanian [:sriram] from comment #6)
> The background color is supplied by android:background property. The
> android:src property can show a LevelDrawable. The current menu level has
> transparency in it for level 2. To provide a "fade" effect, a
> TransistionDrawable can be used. That allows switching between two levels
> with an animation.

Not exactly what we want because the fading would have to happen in sync with the tab counter's animation using an AccelerateInterpolator.

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/ce8381f138cc
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.