897126 - [fig] Menu button visibile in editing mode in private browsing mode

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[:Margaret Leibovic]

Attachment: screenshot

See screenshot.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

I don't like how the menu button is split into two. Should investigate the reason and merge them both into one. But this patch works fine with current code base.

Comment 2

[:Margaret Leibovic]

Comment on attachment 780008 [details] [diff] [review]
Patch

I'm going to redirect this review to lucasr, since he's more familiar with this code.

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 780008 [details] [diff] [review]
Patch

Review of attachment 780008 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch. Menu button split was added so that we could fade out the tab counter and menu icon but keep the dark gray background behind them when the tabs tray is open.

Comment 4

[Sriram Ramasubramanian [:sriram]]

We could have done that with an image level on the menu button right?

Comment 5

[Lucas Rocha (:lucasr)]

(In reply to Sriram Ramasubramanian [:sriram] from comment #4)
> We could have done that with an image level on the menu button right?

How would you go about fading out only the icon while keeping the button's background color using image levels?

Comment 6

[Sriram Ramasubramanian [:sriram]]

The background color is supplied by android:background property. The android:src property can show a LevelDrawable. The current menu level has transparency in it for level 2. To provide a "fade" effect, a TransistionDrawable can be used. That allows switching between two levels with an animation.

Comment 7

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/projects/fig/rev/ce8381f138cc

Comment 8

[Lucas Rocha (:lucasr)]

(In reply to Sriram Ramasubramanian [:sriram] from comment #6)
> The background color is supplied by android:background property. The
> android:src property can show a LevelDrawable. The current menu level has
> transparency in it for level 2. To provide a "fade" effect, a
> TransistionDrawable can be used. That allows switching between two levels
> with an animation.

Not exactly what we want because the fading would have to happen in sync with the tab counter's animation using an AccelerateInterpolator.

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ce8381f138cc