89713 - chatzilla 0.8.4 megapatch

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Robert Ginda]

The changes in the upcomming patch merge in the changes from The Lost ChatZilla,
0.8.1.  These changes rotted away instead of getting checked in.

Changes include
* the /css command, along with light, dark, and "default" stylesheets
* link drag and drop
* a munger rule to turn #channels into irc:// links
* timestamps as tooltips

In addition, these changes include ssieb's patch from bug 89692, and add an
accesskey for the View menu.

There's an xpi available at hacksrus (see the url for this bug.)

ssieb: let me know what bugs you want merged into this patch and I'll take care
of it.  Just make them dependant in this bug or something.

Comment 1

[Robert Ginda]

Attachment: irc.diff; changes, round one

Comment 2

[Robert Ginda]

Attachment: irc/xul/skin/output-dark.css; new file

Comment 3

[Robert Ginda]

Attachment: irc/xul/skin/output-light.css; new file

Comment 4

[Robert Ginda]

Added patch from bug 89717 to the .xpi.

Comment 5

[Robert Ginda]

Here comes an updated patch.  0.8.4 now fixes the 11 bugs marked as blocked by
this one, a few bugs that weren't filed, and adds a some new features.

The new features are...
* context menu in the output window
* the ability to highlight individual users messages retroactivley
* the ability to drag tabs into your bookmarks
* keyboard shortcuts for existing menu items
* menu items for status and "motif" switching

There is still some cleanup work to do.  For now, check out the diff and make
some comments, or just try out the 0.8.4 xpi on hacksrus.

Comment 6

[Robert Ginda]

Attachment: irc.diff; changed files, round two

Comment 7

[Robert Ginda]

Attachment: output-light.css; new file, round two

Comment 8

[Robert Ginda]

Attachment: output-dark.css; new file, round two

Comment 9

[Robert Ginda]

Attachment: xul/content/dynamic.css; new file in round two

Comment 10

[Robert Ginda]

new patches coming up.  This adds the ability to drag irc:// links and .css
files into the chatzilla window.

Comment 11

[Robert Ginda]

Attachment: irc.diff; round three

Comment 12

[Robert Ginda]

Attachment: xul/content/output-base.css; new file in round three

Comment 13

[Jacob Kjome]

thought you might want to know about a crasher bug reported about Mozilla 
crashing on close after having using Chatzilla 0.8.4:  bug 91447

Jake

Comment 14

[Samuel Sieb]

xul/content/dynamic.css
  "epmty css file"
    epmty -> empty

jar.mn
  there's some odd spacing

js/lib/irc.js
  CIRCChannel.prototype.getURL
    why not get the server URL and append the channel to it
    (similar to CIRCUser.prototype.getURL)

xul/content/chatzilla.xul
  <box orient="vertical"/> -> <vbox> (see bug 73671)

xul/content/handlers.js
  +CIRCNetwork.prototype.on323 = /* end of LIST reply */
  +function my_321 (e)     <- should be my_323

xul/content/static.js
  +contentDropObserver.onDrop =
  +function tabdnd_dover (aEvent, aXferData, aDragSession)   <-  should be
tabdnd_ondrop
    so this is probably incorrect as well: getMsg("tabdnd_dover", url)

  function deleteToolbutton (tb)
    you've changed toolbutton everywhere else to tab bar

xul/locale/en-US/chatzilla.dtd
  +<!ENTITY PopupPingCmd.aKey  "i">  "i" -> "I" ?

xul/locale/en-US/chatzilla.properties
  +deleteHelp=Clear the current view, discarding *all* content, and drop it's
icon from the tab strip
    it's -> its
  helpHelp=Displays help on all commands matching <command-name>, if
<command-name> is not given, displays help on all commands"
    why is there a " at the end?
  +hideHelp=Drop the current view's icon from the tab strip, but save it's contents
    it's -> its
  +pingHelp=Attempts to measure the time it takes to send a message to the user
<nick>, and recieve a response.
    recieve -> receive
  queryHelp=Opens a one-on-one chat with <usr>
    <usr> -> <user>
  topicHelp=
    no "." at end
  +tabstripHelp=Toggles the visibility of the channel tabstrip
     tabstrip -> tab strip
  +tabdnd_dover=
     dover -> ondrop ?
  cli_testdisplayMsg20=
    duplicate of cli_testdisplayMsg11?

xul/skin/output-default.css
  +.msg-user:before,
  .msg-user:after {
  +    font: 10pt courier;
  +    font-weight: bolder;
  }
     font change, but no content?

Comment 15

[Robert Ginda]

Attachment: irc.diff; changed files, round four

Comment 16

[Robert Ginda]

I made all of ssieb's changes except "font change, but no content".  The content
is defined in output-base.css.

Also, the latest patch contains fixes to make chatzilla work in the latest
builds, and removes the "highlight" command because it caused crashes in css
code (bug 91447.)

Comment 17

[Asa Dotzler [:asa]]

a=asa on behalf of [e-mail].  don't wait so long next time ;)

Comment 18

[Robert Ginda]

patch checked in