Status

Webmaker
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jbuck, Assigned: jbuck)

Tracking

Details

(Assignee)

Description

4 years ago
helmet, the node module we use to provide HSTS headers, has a bug where it did not send a correctly formatted max-age directive. It's currently being fixed in https://github.com/evilpacket/helmet/issues/10 and we'll need to update the version of helmet to v0.0.11 in all our apps.

Comment 1

4 years ago
Commit pushed to master at https://github.com/mozilla/login.webmaker.org

https://github.com/mozilla/login.webmaker.org/commit/4dc613a018241f61d4e54ce66ed82d140506d732
Bug 897132 - Send correctly formed max-age directive
(Assignee)

Updated

4 years ago
Blocks: 897059

Comment 2

4 years ago
Commit pushed to master at https://github.com/mozilla/MakeAPI

https://github.com/mozilla/MakeAPI/commit/331dfecf3ea036afbd13b2d9ee226b7027a14425
Bug 897132 - Send correctly formed max-age directive

Comment 3

4 years ago
Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/574099b70c9fa598645bdde3f7c6556b9d0e9e9e
Bug 897132 - Send correctly formed max-age directive

Comment 4

4 years ago
Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/a17abf2a58b550e3cb27a4d7b85a69829a8f684d
Bug 897132 - Send correctly formed max-age directive

Comment 5

4 years ago
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/3c08f15fba0b5962fab92bcb634f8152d4cf7e4d
Bug 897132 - Send correctly formed max-age directive
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.