897143 - Update parser algorithms to be namespace aware

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Comment 1

[William Chen [:wchen]]

Attachment: Part 1: Update parsing of template element to spec as of July 15, 2013.

Comment 2

[William Chen [:wchen]]

Attachment: Part 2: Rename TEMPLATE_CONTENTS to IN_TEMPLATE.

Comment 3

[William Chen [:wchen]]

Comment on attachment 779923 [details] [diff] [review]
Part 1: Update parsing of template element to spec as of July 15, 2013.

Attached to wrong bug

Comment 4

[William Chen [:wchen]]

Attachment: Update parser algorithms to be namespace aware.

Comment 5

[Henri Sivonen (:hsivonen)]

Comment on attachment 779928 [details] [diff] [review]
Update parser algorithms to be namespace aware.

The EOF change bothers me, because I fail to see where the spec handles EOF in foreign content. However, I assume you have a good reason for the change.

It seems the namespace check when checking for special but not "p", "address" or "div" is not strictly needed, but maybe it's prudent to have it defensively against future changes.

Comment 6

[William Chen [:wchen]]

(In reply to Henri Sivonen (:hsivonen) from comment #5)
> Comment on attachment 779928 [details] [diff] [review]
> Update parser algorithms to be namespace aware.
> 
> The EOF change bothers me, because I fail to see where the spec handles EOF
> in foreign content. However, I assume you have a good reason for the change.

According to section 8.2.5 (http://www.w3.org/html/wg/drafts/html/master/syntax.html#tree-construction) EOF should be processed according to the current insertion mode in HTML content, thus we do not ever handle it in foreign content. The currently behavior of ignoring it was causing a couple of the new tests to fail.

Comment 7

[Henri Sivonen (:hsivonen)]

(In reply to William Chen [:wchen] from comment #6)
> According to section 8.2.5
> (http://www.w3.org/html/wg/drafts/html/master/syntax.html#tree-construction)
> EOF should be processed according to the current insertion mode in HTML
> content, thus we do not ever handle it in foreign content. The currently
> behavior of ignoring it was causing a couple of the new tests to fail.

OK. The WHATWG spec seems to have the same text.

Comment 8

[William Chen [:wchen]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3328d31f541a

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/3328d31f541a