Closed Bug 897143 Opened 6 years ago Closed 6 years ago

Update parser algorithms to be namespace aware

Categories

(Core :: DOM: HTML Parser, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: wchen, Assigned: wchen)

References

()

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Attachment #779926 - Flags: review?(hsivonen)
Comment on attachment 779923 [details] [diff] [review]
Part 1: Update parsing of template element to spec as of July 15, 2013.

Attached to wrong bug
Attachment #779923 - Attachment is obsolete: true
Attachment #779923 - Flags: review?(hsivonen)
Attachment #779926 - Attachment is obsolete: true
Attachment #779926 - Flags: review?(hsivonen)
Comment on attachment 779928 [details] [diff] [review]
Update parser algorithms to be namespace aware.

The EOF change bothers me, because I fail to see where the spec handles EOF in foreign content. However, I assume you have a good reason for the change.

It seems the namespace check when checking for special but not "p", "address" or "div" is not strictly needed, but maybe it's prudent to have it defensively against future changes.
Attachment #779928 - Flags: review?(hsivonen) → review+
(In reply to Henri Sivonen (:hsivonen) from comment #5)
> Comment on attachment 779928 [details] [diff] [review]
> Update parser algorithms to be namespace aware.
> 
> The EOF change bothers me, because I fail to see where the spec handles EOF
> in foreign content. However, I assume you have a good reason for the change.

According to section 8.2.5 (http://www.w3.org/html/wg/drafts/html/master/syntax.html#tree-construction) EOF should be processed according to the current insertion mode in HTML content, thus we do not ever handle it in foreign content. The currently behavior of ignoring it was causing a couple of the new tests to fail.
(In reply to William Chen [:wchen] from comment #6)
> According to section 8.2.5
> (http://www.w3.org/html/wg/drafts/html/master/syntax.html#tree-construction)
> EOF should be processed according to the current insertion mode in HTML
> content, thus we do not ever handle it in foreign content. The currently
> behavior of ignoring it was causing a couple of the new tests to fail.

OK. The WHATWG spec seems to have the same text.
https://hg.mozilla.org/mozilla-central/rev/3328d31f541a
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.