897168 - Fix up localization for the goggles

Status: RESOLVED FIXED

(Webmaker Graveyard :: X-Ray Goggles, defect)

Description

[Pomax]

Plan of attack:
- write script to convert transifex key-value-json into goggles jquery.localization.extend format
- modify our views/settings.js so that the "language" property uses i18n-abide to figure which language it should be serving,
- create the custom /src/locale/...js files that we need to support any language we need supported.

Comment 1

[Pomax]

idea for settings.js:

(function(jQuery) {
  "use strict";

  function makeAbsoluteURL(baseURI, url) {
    if (url.match(/^https?:/))
      return url;
    return baseURI + url;
  }
  
  jQuery.webxraySettings = {
    extend: jQuery.extend,
    url: function(name) {
      if (jQuery.isArray(this[name])) {
        var self = this;
        return jQuery.map(this[name], function(url) {
          return makeAbsoluteURL(self.baseURI, url);
        });
      }
      return makeAbsoluteURL(this.baseURI, this[name]);
    },
    language: (function() {
      // loaded once, when webxray starts up
      jQuery.getScript("/src/i18n-abide.js");
      // i18n is now loaded, get the client-global language
      var lang = i18n-abide.requestLanguage();
      // make sure webxray, for this uses, uses this langauge,
      // or "en" as fallback language.
      return lang + " en";
    }()),
    baseURI: "",
    cssURL: "webxray.css",
    preferencesURL: "preferences.html",
    easyRemixDialogURL: "easy-remix-dialog/index.html",
    uprootDialogURL: "uproot-dialog.html",
    bugReportDialogURL: "bug-report-dialog.html",
    hackpubURL: "http://hackpub.hackasaurus.org/",
    bugReportHackpubURL: "http://hackpub.hackasaurus.org/buckets/webxray-bugs/",
    hackpubInjectionURL: "published-hack/injector.js",
    pluginURLs: []
  };
})(jQuery);

Comment 2

[Pomax]

we will also need to change the app.js to serve up i18n-abide, of course.

Comment 3

[Pomax]

note that our transifex -> jquery.lo... conversion script would have to generate the files into the ./webxray/src/locale directory

Comment 4

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/goggles.webmaker.org/pull/14

Comment 5

[Pomax]

Comment on attachment 792209 [details] [review]
https://github.com/mozilla/goggles.webmaker.org/pull/14

I will r- until the next iteration, since there are too many comments on the pull request at this point.

Comment 6

[David Humphrey (:humph)]

Comment on attachment 792209 [details] [review]
https://github.com/mozilla/goggles.webmaker.org/pull/14

This is really looking good.  Some feedback in the PR.  I'm unclear if I'll be able to finish the full review of this before my holidays, so don't block on me if it goes beyond today.  Pomax can take over, and Jon if you need more eyes.

Amazing, amazing work here Ali. ^5

Comment 7

[Jon Buckley [:jbuck]]

Comment on attachment 792209 [details] [review]
https://github.com/mozilla/goggles.webmaker.org/pull/14

Looking good to me, please address all of humph's comments though

Comment 8

[Pomax]

Comment on attachment 792209 [details] [review]
https://github.com/mozilla/goggles.webmaker.org/pull/14

couple of notes in the pull request that I'd like addressed before I r+ this.

Comment 9

[Pomax]

Comment on attachment 792209 [details] [review]
https://github.com/mozilla/goggles.webmaker.org/pull/14

r+ with two things: 1) take out th-TH so we don't accidentally land it with bad thai support, an 2) we need to file one or more followups for tackling the things we don't have localised atm: tutorial images, sign in/out include from webmaker.org, etc.