897227 - VariablesView search is slow

Status: RESOLVED WONTFIX

(DevTools :: Object Inspector, defect, P3)

Description

[Brandon Benvie [:benvie]]

Searching the VariablesView is slow (100ms+) when there's an object with a lot of properties (such as the ChromeWindow in the error console). This is probably because the search updates attributes for properties individually, each causing a reflow. This could probably be remedied by detaching the parent element, executing the search, and reattaching it.

Comment 1

[Brandon Benvie [:benvie]]

Detaching/reattaching the VariablesView's _list does not noticeably help performance. This will need more in depth examination.

Comment 2

[Victor Porof [:vporof][:vp]]

(In reply to Brandon Benvie [:bbenvie] from comment #0)

Isn't this because of the timeout set before actually starting the search? Does hitting Enter or searching for longer keywords alleviate the situation?

Comment 3

[Brandon Benvie [:benvie]]

(In reply to Victor Porof [:vp] from comment #2)
> Isn't this because of the timeout set before actually starting the search?
> Does hitting Enter or searching for longer keywords alleviate the situation?

No, I think it's definitely something performance related, because the UI becomes unresponsive. Steps to reproduce:

* Go to the browser console and open `this` up in the VariablesView
* type "Add"
* rapidly backspace three times

You will see it immediately backspace the first "d" and regenerate the list, then the UI will stall for 50-100ms before removing the second "d" and regenerating the list. Also doing <backspace> <backspace> <enter> doesn't make it respond any faster.

Comment 4

[Patrick Brosset <:pbro>]

The vview is only used in scratchpad and webaudio now. Closing this old bug.