Closed Bug 897275 Opened 11 years ago Closed 11 years ago

Move css-logic.js to toolkit

Categories

(DevTools :: Inspector, defect)

Product:
DevTools
Component:
Inspector
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 26

People

(Reporter: dcamp, Assigned: dcamp)

Details

Attachments

(1 file, 2 obsolete files)

move-csslogic.diff
3.70 KB, patch
gps
: review+
Details | Diff | Splinter Review
Attached patch move-csslogic.diff (obsolete) — — Splinter Review 
This leaves the same require path for css-logic, but includes it in toolkit builds.  I'm not going to mess with the tests right now, that'll resolve itself when we merge toolkit/devtools and browser/devtools.
Attached patch move-csslogic.diff (obsolete) — — Splinter Review 

        Attachment #785833 -
        Flags: review?(jwalker)

    
  

        Attachment #780074 -
        Attachment is obsolete: true

        Attachment #785833 -
        Flags: review?(jwalker) → review+

    
    

    
  
https://hg.mozilla.org/integration/fx-team/rev/ec45d9c75316
Assignee: nobody → dcamp
Whiteboard: [fixed-in-fx-team]

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/ec45d9c75316
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26

    
    

    
  
Non-trivial Makefile changes and additions need build config review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/54cdd84b2989
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
  

        Attachment #785833 -
        Flags: review?(gps)

    
    

    
  
Comment on attachment 785833 [details] [diff] [review]
move-csslogic.diff

Review of attachment 785833 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/styleinspector/Makefile.in
@@ +11,5 @@
> +
> +include $(topsrcdir)/config/rules.mk
> +
> +libs::
> +	$(INSTALL) $(IFLAGS1) $(srcdir)/*.js $(FINAL_TARGET)/modules/devtools/styleinspector

This works but is not proper.

The proper way to do this is to define EXTRA_JS_MODULES in a moz.build file. See |mach mozbuild-reference| and search for EXTRA_JS_MODULES. Moving this will make this Makefile.in empty and empty Makefile.in can be deleted.

        Attachment #785833 -
        Flags: review?(gps) → review-

    
    

    
  


  

        Attachment #785833 -
        Attachment is obsolete: true

        Attachment #787829 -
        Flags: review?(gps)

    
    

    
  
Comment on attachment 787829 [details] [diff] [review]
move-csslogic.diff

Review of attachment 787829 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect.

FYI you have a double Mercurial patch header.

        Attachment #787829 -
        Flags: review?(gps) → review+

    
    

    
  
https://hg.mozilla.org/integration/fx-team/rev/53a0468d797f
Whiteboard: [fixed-in-fx-team]

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/53a0468d797f
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: