Closed
Bug 897280
Opened 12 years ago
Closed 10 years ago
Browser window should state title of saved project instead of generic "Popcorn Maker"
Categories
(Webmaker Graveyard :: Popcorn Maker, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: Jacob, Assigned: pbouianov)
Details
Attachments
(1 file)
56 bytes,
patch
|
thecount
:
review+
|
Details | Diff | Splinter Review |
When you save a project in Popcorn Maker, or load a previously saved project, the title of the browser tab/window reads "Popcorn Maker"
Instead, saving a project should generate a <title> tag that implements the title of the project itself.
That way you can see at a glance the title of your project, especially useful when you have multiple Popcorn Maker tabs open.
Right now they all say the same thing, "Popcorn Maker"
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #820011 -
Flags: review?(scott)
Comment 3•11 years ago
|
||
Comment on attachment 820011 [details] [diff] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/282
Looks good to me.
I'll land this in the morning.
Attachment #820011 -
Flags: review?(scott) → review+
Updated•11 years ago
|
Flags: needinfo?(scott)
Comment 4•11 years ago
|
||
Looks like to be on the safe side, we're landing things to staging tomorrow and not today.
Comment 5•11 years ago
|
||
Comment on attachment 820011 [details] [diff] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/282
I was about to land this, and then noticed there is a string that needs to be properly localized.
Luckily it is easy.
Where we have " - Popcorn Maker" used, change it so the string is passed to a Localized.get call. Don't pass in the " - " as "Popcorn Maker" is a key value to an already potentially translated string.
So probably best to append the " - " + Localized.get
Sorry I didn't catch this sooner.
Let me know if you have any problems.
Attachment #820011 -
Flags: review+ → review-
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 820011 [details] [diff] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/282
Updated
Attachment #820011 -
Flags: review- → review?(scott)
Comment 7•11 years ago
|
||
Comment on attachment 820011 [details] [diff] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/282
One last comment and we should be good.
Attachment #820011 -
Flags: review?(scott) → review-
Updated•11 years ago
|
Assignee: scott → petr.bouianov
Flags: needinfo?(scott)
Assignee | ||
Comment 8•11 years ago
|
||
Comment on attachment 820011 [details] [diff] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/282
missing string localized
Attachment #820011 -
Flags: review- → review?(scott)
Comment 9•11 years ago
|
||
Comment on attachment 820011 [details] [diff] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/282
I think this is good to go now, squashing the commits into one, and landing now.
Attachment #820011 -
Flags: review?(scott) → review+
Comment 10•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org
https://github.com/mozilla/popcorn.webmaker.org/commit/129721c56b2b91a2b75bbf4054527bb4d1a4f72f
Bug 897280 - Displaying title of saved project instead of generic 'Popcorn Maker'
Comment 11•11 years ago
|
||
Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/129721c56b2b91a2b75bbf4054527bb4d1a4f72f
Needs verification.
Updated•11 years ago
|
Status: NEW → ASSIGNED
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•