[Settings] No scroll in input PUK screen

RESOLVED FIXED in Firefox OS v1.1hd

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Leo, Assigned: Leo)

Tracking

unspecified
1.1 QE5
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

Details

(Whiteboard: [TD-68404][LeoVB+])

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 780092 [details]
PUK.mp4

1. Title : No scroll in input PUK screen
2. Precondition : Type the wrong PIN 3 times
3. Tester's Action : Type the wrong PUK and press OK
4. Detailed Symptom : There is no scroll
5. Expected : It should be possible to scroll the screen.
6. Reproducibility: Y
   - Frequency Rate : 100%
7.Gaia Master/v1-train : Reproduced
8. Version Info
Gaia : 0d5a9a7577f16b6a72a982148c6f509ee1714ea2
Gecko : 499c1f8ea7ad0cdaa7086214278e2944b8a2ea33
(Assignee)

Updated

5 years ago
Whiteboard: [TD-68404]
Target Milestone: --- → 1.1 QE5
(Assignee)

Comment 1

5 years ago
Created attachment 780129 [details] [diff] [review]
PUK_scroll.patch

Please check the patch.
Attachment #780129 - Flags: review?(kaze)
(Assignee)

Comment 2

5 years ago
Created attachment 780891 [details] [diff] [review]
system_PUK_scroll.patch

Please review the patch
Attachment #780129 - Attachment is obsolete: true
Attachment #780129 - Flags: review?(kaze)
Attachment #780891 - Flags: review?(ehung)
Comment on attachment 780891 [details] [diff] [review]
system_PUK_scroll.patch

Please help review and test it. Thanks!
Attachment #780891 - Flags: review?(ehung) → review?(arthur.chen)
(Assignee)

Comment 4

4 years ago
Created attachment 782963 [details] [diff] [review]
system_PUK_scroll.patch

I found a regression so I has uploaded the patch again. Please check again.
Attachment #780891 - Attachment is obsolete: true
Attachment #780891 - Flags: review?(arthur.chen)
Attachment #782963 - Flags: review?(arthur.chen)
(Assignee)

Updated

4 years ago
Whiteboard: [TD-68404] → [TD-68404][LeoVB+]
Comment on attachment 782963 [details] [diff] [review]
system_PUK_scroll.patch

The patch made changes to the style in system, redirect to alive.
Attachment #782963 - Flags: review?(arthur.chen) → review?(alive)
Comment on attachment 782963 [details] [diff] [review]
system_PUK_scroll.patch

Review of attachment 782963 [details] [diff] [review]:
-----------------------------------------------------------------

r=me.
Attachment #782963 - Flags: review?(alive) → review+
Hi John,

Please confirm if this bug has landed on b2g 18? 1.1
Flags: needinfo?(jhford)
(In reply to Preeti Raghunath(:Preeti) from comment #7)
> Hi John,
> 
> Please confirm if this bug has landed on b2g 18? 1.1

This is not landed anywhere yet.
Flags: needinfo?(jhford)
Alive,

Can you please land this bug fix on b2g18?
Flags: needinfo?(alive)
v1-train
https://github.com/mozilla-b2g/gaia/commit/a7b8037f1f1bcafcfd5fbad7cd74f7e22bb80166

master
https://github.com/mozilla-b2g/gaia/commit/28352c4d9e7f591793acca82613e908218edc252
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-b2g18: --- → fixed
Flags: needinfo?(alive)
Resolution: --- → FIXED
v1.1.0hd: a7b8037f1f1bcafcfd5fbad7cd74f7e22bb80166
v1.1.0hd: 284dfb81b4988f23ff49836fe6d2c852d49222b9
status-b2g-v1.1hd: --- → fixed

Updated

4 years ago
Assignee: nobody → leo.bugzilla.gaia
You need to log in before you can comment on or make changes to this bug.